From 36bf1a80bf924a0130480b316429ee6b42b8125b Mon Sep 17 00:00:00 2001
From: Inex Code <inex.code@selfprivacy.org>
Date: Mon, 2 May 2022 14:48:28 +0300
Subject: [PATCH] Fix username length check

---
 selfprivacy_api/app.py              | 2 +-
 selfprivacy_api/resources/common.py | 2 +-
 selfprivacy_api/resources/users.py  | 2 +-
 tests/test_users.py                 | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/selfprivacy_api/app.py b/selfprivacy_api/app.py
index 03e86a1..18dc4bd 100644
--- a/selfprivacy_api/app.py
+++ b/selfprivacy_api/app.py
@@ -68,7 +68,7 @@ def create_app(test_config=None):
     def spec():
         if app.config["ENABLE_SWAGGER"] == "1":
             swag = swagger(app)
-            swag["info"]["version"] = "1.2.3"
+            swag["info"]["version"] = "1.2.4"
             swag["info"]["title"] = "SelfPrivacy API"
             swag["info"]["description"] = "SelfPrivacy API"
             swag["securityDefinitions"] = {
diff --git a/selfprivacy_api/resources/common.py b/selfprivacy_api/resources/common.py
index 2955165..6658cbf 100644
--- a/selfprivacy_api/resources/common.py
+++ b/selfprivacy_api/resources/common.py
@@ -23,4 +23,4 @@ class ApiVersion(Resource):
             401:
                 description: Unauthorized
         """
-        return {"version": "1.2.3"}
+        return {"version": "1.2.4"}
diff --git a/selfprivacy_api/resources/users.py b/selfprivacy_api/resources/users.py
index 747e33a..4a2c464 100644
--- a/selfprivacy_api/resources/users.py
+++ b/selfprivacy_api/resources/users.py
@@ -89,7 +89,7 @@ class Users(Resource):
         if not re.match(r"^[a-z_][a-z0-9_]+$", args["username"]):
             return {"error": "username must be alphanumeric"}, 400
         # Check if username less than 32 characters
-        if len(args["username"]) > 32:
+        if len(args["username"]) >= 32:
             return {"error": "username must be less than 32 characters"}, 400
 
         with WriteUserData() as data:
diff --git a/tests/test_users.py b/tests/test_users.py
index bc07951..1ca358d 100644
--- a/tests/test_users.py
+++ b/tests/test_users.py
@@ -213,7 +213,7 @@ def test_post_user_to_undefined_users(
 
 def test_post_very_long_username(authorized_client, one_user, mock_subprocess_popen):
     response = authorized_client.post(
-        "/users", json={"username": "a" * 100, "password": "password"}
+        "/users", json={"username": "a" * 32, "password": "password"}
     )
     assert response.status_code == 400