From 3bf4cafb0af550558bfe1712f4c69917106d9cf4 Mon Sep 17 00:00:00 2001 From: dettlaff Date: Tue, 10 Dec 2024 22:06:47 +0400 Subject: [PATCH] fix: kanidm errors comparison --- .../repositories/users/kanidm_user_repository.py | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/selfprivacy_api/repositories/users/kanidm_user_repository.py b/selfprivacy_api/repositories/users/kanidm_user_repository.py index 7a76872..b38b559 100644 --- a/selfprivacy_api/repositories/users/kanidm_user_repository.py +++ b/selfprivacy_api/repositories/users/kanidm_user_repository.py @@ -155,9 +155,11 @@ class KanidmUserRepository(AbstractUserRepository): response = response.json() - if response["plugin"]: - if response["plugin"].get("attrunique") == "duplicate value detected": + if response and response != []: + if response[0]["plugin"].get("attrunique") == "duplicate value detected": raise UserAlreadyExists # TODO only user? + else: + raise KanidmReturnEmptyResponse return response @@ -217,9 +219,6 @@ class KanidmUserRepository(AbstractUserRepository): """ users_data = KanidmUserRepository._send_query(endpoint="person", method="GET") - if not users_data: - raise KanidmReturnEmptyResponse - users = [] for user in users_data: user_attrs = user.get("attrs", {}) @@ -291,9 +290,6 @@ class KanidmUserRepository(AbstractUserRepository): method="GET", ) - if not user_data or "attrs" not in user_data: - raise KanidmReturnEmptyResponse - attrs = user_data["attrs"] return UserDataUser( @@ -319,9 +315,6 @@ class KanidmUserRepository(AbstractUserRepository): method="GET", ) - if not data: - raise KanidmReturnEmptyResponse - token = data.get("token", None) if not token: