From 63ea78b1ef369bd835ded236f91ab477243e6fbf Mon Sep 17 00:00:00 2001 From: dettlaff Date: Wed, 11 Dec 2024 04:03:58 +0400 Subject: [PATCH] fix: delete block try except in wrong place --- .../users/kanidm_user_repository.py | 41 +++++++++---------- 1 file changed, 20 insertions(+), 21 deletions(-) diff --git a/selfprivacy_api/repositories/users/kanidm_user_repository.py b/selfprivacy_api/repositories/users/kanidm_user_repository.py index 3ef8cf6..967fd81 100644 --- a/selfprivacy_api/repositories/users/kanidm_user_repository.py +++ b/selfprivacy_api/repositories/users/kanidm_user_repository.py @@ -146,30 +146,29 @@ class KanidmUserRepository(AbstractUserRepository): timeout=0.8, # TODO: change timeout verify=False, # TODO: REMOVE THIS NOTHALAL!!!!! ) - - logger.info(str(response)) - response_data = response.json() - - plugin_error = response_data.get("plugin", {}) - if plugin_error.get("attrunique") == "duplicate value detected": - raise UserAlreadyExists # TODO only user ? - - if response.status_code != 200: - raise KanidmQueryError( - f"Kanidm returned {response.status_code} unexpected HTTP status code. Endpoint: {full_endpoint}. Error: {response.text}." - ) - - if ( - isinstance(response_data, dict) - and response_data.get("data") is not None - ): - return response_data - else: - raise KanidmReturnEmptyResponse - except Exception as error: raise KanidmQueryError(f"Kanidm request failed! Error: {str(error)}") + logger.info(str(response)) + response_data = response.json() + + plugin_error = response_data.get("plugin", {}) + if plugin_error.get("attrunique") == "duplicate value detected": + raise UserAlreadyExists # TODO only user ? + + if response.status_code != 200: + raise KanidmQueryError( + f"Kanidm returned {response.status_code} unexpected HTTP status code. Endpoint: {full_endpoint}. Error: {response.text}." + ) + + if ( + isinstance(response_data, dict) + and response_data.get("data") is not None + ): + return response_data + else: + raise KanidmReturnEmptyResponse + # nomatchingentries @staticmethod