From cf3e6fe39e9397456772b02b7d6aba4e184415e4 Mon Sep 17 00:00:00 2001 From: dettlaff Date: Wed, 11 Dec 2024 05:48:30 +0400 Subject: [PATCH] feat: add new errors processing --- selfprivacy_api/graphql/common_types/user.py | 1 + selfprivacy_api/graphql/mutations/users_mutations.py | 12 ++++++++++-- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/selfprivacy_api/graphql/common_types/user.py b/selfprivacy_api/graphql/common_types/user.py index 4f234d9..78bf52f 100644 --- a/selfprivacy_api/graphql/common_types/user.py +++ b/selfprivacy_api/graphql/common_types/user.py @@ -47,6 +47,7 @@ class PasswordResetLinkReturn(MutationReturnInterface): def get_user_by_username(username: str) -> Optional[User]: + # TODO: why isn't there TRY user = actions_get_user_by_username(username=username) if user is None: return None diff --git a/selfprivacy_api/graphql/mutations/users_mutations.py b/selfprivacy_api/graphql/mutations/users_mutations.py index 7aca6d8..7d68b39 100644 --- a/selfprivacy_api/graphql/mutations/users_mutations.py +++ b/selfprivacy_api/graphql/mutations/users_mutations.py @@ -39,10 +39,12 @@ from selfprivacy_api.repositories.users.exceptions import ( UserNotFound, SelfPrivacyAppIsOutdate, ) -from selfprivacy_api import PLEASE_UPDATE_APP_TEXT -from selfprivacy_api.repositories.users.kanidm_user_repository import ( +from selfprivacy_api.repositories.users.exceptions_kanidm import ( KanidmDidNotReturnAdminPassword, + KanidmReturnEmptyResponse, + KanidmReturnUnknownResponseType, ) +from selfprivacy_api import PLEASE_UPDATE_APP_TEXT FAILED_TO_SETUP_PASSWORD_TEXT = "Failed to set a password for a user. The problem occurred due to an old version of the SelfPrivacy app." @@ -98,6 +100,8 @@ class UsersMutations: UsernameTooLong, InvalidConfiguration, KanidmDidNotReturnAdminPassword, + KanidmReturnUnknownResponseType, + KanidmReturnEmptyResponse, ) as error: return return_failed_mutation_return( message=error.get_error_message(), @@ -171,6 +175,8 @@ class UsersMutations: PasswordIsEmpty, SelfPrivacyAppIsOutdate, KanidmDidNotReturnAdminPassword, + KanidmReturnUnknownResponseType, + KanidmReturnEmptyResponse, ) as error: return return_failed_mutation_return( message=error.get_error_message(), @@ -260,6 +266,8 @@ class UsersMutations: NoPasswordResetLinkFoundInResponse, KanidmDidNotReturnAdminPassword, RootIsNotAvailableForModification, + KanidmReturnUnknownResponseType, + KanidmReturnEmptyResponse, ) as error: return PasswordResetLinkReturn( success=False,