From 0b5f8b6920532205ebf4d2a0361dd9d6b581e2e7 Mon Sep 17 00:00:00 2001
From: NaiJi <naijiworld@protonmail.com>
Date: Sat, 8 Oct 2022 16:17:58 +0000
Subject: [PATCH] fix(job): Remove unnecessary cascade validation calls
---
lib/logic/models/job.dart | 28 +++++++++++++---------------
1 file changed, 13 insertions(+), 15 deletions(-)
diff --git a/lib/logic/models/job.dart b/lib/logic/models/job.dart
index cf55be9e..076e0d16 100644
--- a/lib/logic/models/job.dart
+++ b/lib/logic/models/job.dart
@@ -32,7 +32,7 @@ class RebuildServerJob extends ClientJob {
@override
bool canAddTo(final List<ClientJob> jobs) =>
- super.canAddTo(jobs) && !jobs.any((final job) => job is RebuildServerJob);
+ !jobs.any((final job) => job is RebuildServerJob);
@override
void execute(final JobsCubit cubit) async {
@@ -80,10 +80,9 @@ class DeleteUserJob extends ClientJob {
final User user;
@override
- bool canAddTo(final List<ClientJob> jobs) =>
- super.canAddTo(jobs) &&
- !jobs.any(
- (final job) => job is DeleteUserJob && job.user.login == user.login);
+ bool canAddTo(final List<ClientJob> jobs) => !jobs.any(
+ (final job) => job is DeleteUserJob && job.user.login == user.login,
+ );
@override
void execute(final JobsCubit cubit) async {
@@ -107,10 +106,9 @@ class ServiceToggleJob extends ClientJob {
final Service service;
@override
- bool canAddTo(final List<ClientJob> jobs) =>
- super.canAddTo(jobs) &&
- !jobs.any((final job) =>
- job is ServiceToggleJob && job.service.id == service.id);
+ bool canAddTo(final List<ClientJob> jobs) => !jobs.any(
+ (final job) => job is ServiceToggleJob && job.service.id == service.id,
+ );
@override
void execute(final JobsCubit cubit) async {
@@ -149,12 +147,12 @@ class DeleteSSHKeyJob extends ClientJob {
final String publicKey;
@override
- bool canAddTo(final List<ClientJob> jobs) =>
- super.canAddTo(jobs) &&
- !jobs.any((final job) =>
- job is DeleteSSHKeyJob &&
- job.publicKey == publicKey &&
- job.user.login == user.login);
+ bool canAddTo(final List<ClientJob> jobs) => !jobs.any(
+ (final job) =>
+ job is DeleteSSHKeyJob &&
+ job.publicKey == publicKey &&
+ job.user.login == user.login,
+ );
@override
void execute(final JobsCubit cubit) async {