From f7f791cc0c8f2130c2d8ac02d64b8c741a9ce41d Mon Sep 17 00:00:00 2001
From: Aliaksei Tratseuski <aliaksei.tratseuski@gmail.com>
Date: Sun, 30 Jun 2024 18:47:26 +0400
Subject: [PATCH] feat: console_page - cleaned up dead code and unused l10n
 strings

---
 assets/translations/en.json                 |  2 -
 lib/ui/pages/more/console/console_page.dart | 91 ++++++---------------
 2 files changed, 27 insertions(+), 66 deletions(-)

diff --git a/assets/translations/en.json b/assets/translations/en.json
index 9f672acd..234e0702 100644
--- a/assets/translations/en.json
+++ b/assets/translations/en.json
@@ -46,12 +46,10 @@
     },
     "console_page": {
         "title": "Console",
-        "waiting": "Waiting for initialization…",
         "copy": "Copy",
         "copy_raw": "Raw response",
         "history_empty": "No data yet",
         "error": "Error",
-        "log": "Log",
         "rest_api_request": "Rest API Request",
         "rest_api_response": "Rest API Response",
         "graphql_request": "GraphQL Request",
diff --git a/lib/ui/pages/more/console/console_page.dart b/lib/ui/pages/more/console/console_page.dart
index e69eb2fe..6c549a70 100644
--- a/lib/ui/pages/more/console/console_page.dart
+++ b/lib/ui/pages/more/console/console_page.dart
@@ -1,7 +1,6 @@
 import 'package:auto_route/auto_route.dart';
 import 'package:easy_localization/easy_localization.dart';
 import 'package:flutter/material.dart';
-import 'package:gap/gap.dart';
 import 'package:selfprivacy/config/get_it_config.dart';
 import 'package:selfprivacy/logic/models/console_log.dart';
 import 'package:selfprivacy/ui/pages/more/console/console_log_item_widget.dart';
@@ -18,21 +17,15 @@ class ConsolePage extends StatefulWidget {
 class _ConsolePageState extends State<ConsolePage> {
   ConsoleModel get console => getIt<ConsoleModel>();
 
-  /// should freeze logs state to properly read logs
-  late final Future<void> future;
-
   @override
   void initState() {
     super.initState();
-
-    future = getIt.allReady();
     console.addListener(update);
   }
 
   @override
   void dispose() {
     console.removeListener(update);
-
     super.dispose();
   }
 
@@ -48,66 +41,36 @@ class _ConsolePageState extends State<ConsolePage> {
   }
 
   @override
-  Widget build(final BuildContext context) => SafeArea(
-        child: Scaffold(
-          appBar: AppBar(
-            title: Text('console_page.title'.tr()),
-            leading: IconButton(
-              icon: const Icon(Icons.arrow_back),
-              onPressed: () => Navigator.of(context).maybePop(),
-            ),
-            actions: [
-              IconButton(
-                icon: Icon(
-                  console.paused
-                      ? Icons.play_arrow_outlined
-                      : Icons.pause_outlined,
-                ),
-                onPressed: console.paused ? console.play : console.pause,
+  Widget build(final BuildContext context) {
+    final List<ConsoleLog> logs = console.logs;
+
+    return SafeArea(
+      child: Scaffold(
+        appBar: AppBar(
+          title: Text('console_page.title'.tr()),
+          leading: IconButton(
+            icon: const Icon(Icons.arrow_back),
+            onPressed: () => Navigator.of(context).maybePop(),
+          ),
+          actions: [
+            IconButton(
+              icon: Icon(
+                console.paused
+                    ? Icons.play_arrow_outlined
+                    : Icons.pause_outlined,
               ),
-            ],
-          ),
-          body: Scrollbar(
-            child: FutureBuilder(
-              future: future,
-              builder: (
-                final BuildContext context,
-                final AsyncSnapshot<void> snapshot,
-              ) {
-                if (snapshot.hasData) {
-                  final List<ConsoleLog> logs = console.logs;
-
-                  return logs.isEmpty
-                      ? const _ConsoleViewEmpty()
-                      : _ConsoleViewLoaded(logs: logs);
-                }
-
-                return const _ConsoleViewLoading();
-              },
+              onPressed: console.paused ? console.play : console.pause,
             ),
-          ),
+          ],
         ),
-      );
-}
-
-class _ConsoleViewLoading extends StatelessWidget {
-  const _ConsoleViewLoading();
-
-  @override
-  Widget build(final BuildContext context) => Column(
-        mainAxisAlignment: MainAxisAlignment.center,
-        mainAxisSize: MainAxisSize.min,
-        crossAxisAlignment: CrossAxisAlignment.stretch,
-        children: [
-          Text('console_page.waiting'.tr()),
-          const Gap(16),
-          const Expanded(
-            child: Center(
-              child: CircularProgressIndicator.adaptive(),
-            ),
-          ),
-        ],
-      );
+        body: Scrollbar(
+          child: logs.isEmpty
+              ? const _ConsoleViewEmpty()
+              : _ConsoleViewLoaded(logs: logs),
+        ),
+      ),
+    );
+  }
 }
 
 class _ConsoleViewEmpty extends StatelessWidget {