From b4d391f45f38f57b3dfef575802f4ad5898c56a6 Mon Sep 17 00:00:00 2001 From: Josip Miskovic Date: Thu, 12 Nov 2020 18:28:59 +0100 Subject: [PATCH] Change default damping threshold to zero Zero as default makes more sense. Colliders can come to full stop which allows them to go to sleep for CPU optimization. Also in zero gravity colliders crawling through air with 0.01 velocity are infuriating. --- src/api/l_physics_collider.c | 4 ++-- src/api/l_physics_world.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/api/l_physics_collider.c b/src/api/l_physics_collider.c index 7bc48d01..e8e459b2 100644 --- a/src/api/l_physics_collider.c +++ b/src/api/l_physics_collider.c @@ -301,7 +301,7 @@ static int l_lovrColliderGetLinearDamping(lua_State* L) { static int l_lovrColliderSetLinearDamping(lua_State* L) { Collider* collider = luax_checktype(L, 1, Collider); float damping = luax_checkfloat(L, 2); - float threshold = luax_optfloat(L, 3, .01f); + float threshold = luax_optfloat(L, 3, 0.0f); lovrColliderSetLinearDamping(collider, damping, threshold); return 0; } @@ -318,7 +318,7 @@ static int l_lovrColliderGetAngularDamping(lua_State* L) { static int l_lovrColliderSetAngularDamping(lua_State* L) { Collider* collider = luax_checktype(L, 1, Collider); float damping = luax_checkfloat(L, 2); - float threshold = luax_optfloat(L, 3, .01f); + float threshold = luax_optfloat(L, 3, 0.0f); lovrColliderSetAngularDamping(collider, damping, threshold); return 0; } diff --git a/src/api/l_physics_world.c b/src/api/l_physics_world.c index e6c73a8b..65647d07 100644 --- a/src/api/l_physics_world.c +++ b/src/api/l_physics_world.c @@ -267,7 +267,7 @@ static int l_lovrWorldGetLinearDamping(lua_State* L) { static int l_lovrWorldSetLinearDamping(lua_State* L) { World* world = luax_checktype(L, 1, World); float damping = luax_checkfloat(L, 2); - float threshold = luax_optfloat(L, 3, .01f); + float threshold = luax_optfloat(L, 3, 0.0f); lovrWorldSetLinearDamping(world, damping, threshold); return 0; } @@ -284,7 +284,7 @@ static int l_lovrWorldGetAngularDamping(lua_State* L) { static int l_lovrWorldSetAngularDamping(lua_State* L) { World* world = luax_checktype(L, 1, World); float damping = luax_checkfloat(L, 2); - float threshold = luax_optfloat(L, 3, .01f); + float threshold = luax_optfloat(L, 3, 0.0f); lovrWorldSetAngularDamping(world, damping, threshold); return 0; }