From e5ccd6d9131e50e4571f1287a5be5232051e9948 Mon Sep 17 00:00:00 2001
From: Mikhail Klementev <blame@dumpstack.io>
Date: Sun, 29 Dec 2019 16:31:22 +0000
Subject: [PATCH] Move out xml template

---
 appvm.go | 74 ---------------------------------------------------
 xml.go   | 80 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 80 insertions(+), 74 deletions(-)
 create mode 100644 xml.go

diff --git a/appvm.go b/appvm.go
index ada561c..4559aa2 100644
--- a/appvm.go
+++ b/appvm.go
@@ -30,74 +30,6 @@ import (
 	kingpin "gopkg.in/alecthomas/kingpin.v2"
 )
 
-var xmlTmpl = `
-<domain type='kvm' xmlns:qemu='http://libvirt.org/schemas/domain/qemu/1.0'>
-  <name>%s</name>
-  <memory unit='GiB'>2</memory>
-  <currentMemory unit='GiB'>1</currentMemory>
-  <vcpu>4</vcpu>
-  <os>
-    <type arch='x86_64' machine='pc-i440fx-2.12'>hvm</type>
-    <kernel>%s/kernel</kernel>
-    <initrd>%s/initrd</initrd>
-    <cmdline>loglevel=4 init=%s/init %s</cmdline>
-  </os>
-  <features>
-    <acpi/>
-  </features>
-  <clock offset='utc'/>
-  <on_poweroff>destroy</on_poweroff>
-  <on_reboot>restart</on_reboot>
-  <on_crash>destroy</on_crash>
-  <devices>
-    <!-- Graphical console -->
-    <graphics type='spice' autoport='yes'>
-      <listen type='address'/>
-      <image compression='off'/>
-    </graphics>
-    <!-- Guest additionals support -->
-    <channel type='spicevmc'>
-      <target type='virtio' name='com.redhat.spice.0'/>
-    </channel>
-    <!-- Fake (because -snapshot) writeback image -->
-    <disk type='file' device='disk'>
-      <driver name='qemu' type='qcow2' cache='writeback' error_policy='report'/>
-      <source file='%s'/>
-      <target dev='vda' bus='virtio'/>
-    </disk>
-    <video>
-      <model type='qxl' ram='524288' vram='524288' vgamem='262144' heads='1' primary='yes'/>
-      <address type='pci' domain='0x0000' bus='0x00' slot='0x02' function='0x0'/>
-    </video>
-    <!-- filesystems -->
-    <filesystem type='mount' accessmode='passthrough'>
-      <source dir='/nix/store'/>
-      <target dir='store'/>
-      <readonly/>
-    </filesystem>
-    <filesystem type='mount' accessmode='mapped'>
-      <source dir='%s'/>
-      <target dir='xchg'/> <!-- workaround for nixpkgs/nixos/modules/virtualisation/qemu-vm.nix -->
-    </filesystem>
-    <filesystem type='mount' accessmode='mapped'>
-      <source dir='%s'/>
-      <target dir='shared'/> <!-- workaround for nixpkgs/nixos/modules/virtualisation/qemu-vm.nix -->
-    </filesystem>
-    <filesystem type='mount' accessmode='mapped'>
-      <source dir='%s'/>
-      <target dir='home'/>
-    </filesystem>
-  </devices>
-  <qemu:commandline>
-    <qemu:arg value='-device'/>
-    <qemu:arg value='e1000,netdev=net0'/>
-    <qemu:arg value='-netdev'/>
-    <qemu:arg value='user,id=net0'/>
-    <qemu:arg value='-snapshot'/>
-  </qemu:commandline>
-</domain>
-`
-
 func evalNix(expr string) (s string) {
 	command := exec.Command("nix", "eval", "--raw", expr)
 	bytes, _ := command.Output()
@@ -135,12 +67,6 @@ func getAppVMExpressionPath(name string) string {
 
 }
 
-func generateXML(name, vmNixPath, reginfo, img, sharedDir string) string {
-	// TODO: Define XML in go
-	return fmt.Sprintf(xmlTmpl, "appvm_"+name, vmNixPath, vmNixPath, vmNixPath,
-		reginfo, img, sharedDir, sharedDir, sharedDir)
-}
-
 func list(l *libvirt.Libvirt) {
 	domains, err := l.Domains()
 	if err != nil {
diff --git a/xml.go b/xml.go
new file mode 100644
index 0000000..d6d6fbf
--- /dev/null
+++ b/xml.go
@@ -0,0 +1,80 @@
+package main
+
+import "fmt"
+
+// You may think that you want to rewrite to proper golang structures.
+// Believe me, you shouldn't.
+
+func generateXML(name, vmNixPath, reginfo, img, sharedDir string) string {
+	// TODO: Define XML in go
+	return fmt.Sprintf(xmlTmpl, "appvm_"+name, vmNixPath, vmNixPath, vmNixPath,
+		reginfo, img, sharedDir, sharedDir, sharedDir)
+}
+
+var xmlTmpl = `
+<domain type='kvm' xmlns:qemu='http://libvirt.org/schemas/domain/qemu/1.0'>
+  <name>%s</name>
+  <memory unit='GiB'>2</memory>
+  <currentMemory unit='GiB'>1</currentMemory>
+  <vcpu>4</vcpu>
+  <os>
+    <type arch='x86_64' machine='pc-i440fx-2.12'>hvm</type>
+    <kernel>%s/kernel</kernel>
+    <initrd>%s/initrd</initrd>
+    <cmdline>loglevel=4 init=%s/init %s</cmdline>
+  </os>
+  <features>
+    <acpi></acpi>
+  </features>
+  <clock offset='utc'/>
+  <on_poweroff>destroy</on_poweroff>
+  <on_reboot>restart</on_reboot>
+  <on_crash>destroy</on_crash>
+  <devices>
+    <!-- Graphical console -->
+    <graphics type='spice' autoport='yes'>
+      <listen type='address'/>
+      <image compression='off'/>
+    </graphics>
+    <!-- Guest additionals support -->
+    <channel type='spicevmc'>
+      <target type='virtio' name='com.redhat.spice.0'/>
+    </channel>
+    <!-- Fake (because -snapshot) writeback image -->
+    <disk type='file' device='disk'>
+      <driver name='qemu' type='qcow2' cache='writeback' error_policy='report'/>
+      <source file='%s'/>
+      <target dev='vda' bus='virtio'/>
+    </disk>
+    <video>
+      <model type='qxl' ram='524288' vram='524288' vgamem='262144' heads='1' primary='yes'/>
+      <address type='pci' domain='0x0000' bus='0x00' slot='0x02' function='0x0'/>
+    </video>
+    <!-- filesystems -->
+    <filesystem type='mount' accessmode='passthrough'>
+      <source dir='/nix/store'/>
+      <target dir='store'/>
+      <readonly/>
+    </filesystem>
+    <filesystem type='mount' accessmode='mapped'>
+      <source dir='%s'/>
+      <target dir='xchg'/> <!-- workaround for nixpkgs/nixos/modules/virtualisation/qemu-vm.nix -->
+    </filesystem>
+    <filesystem type='mount' accessmode='mapped'>
+      <source dir='%s'/>
+      <target dir='shared'/> <!-- workaround for nixpkgs/nixos/modules/virtualisation/qemu-vm.nix -->
+    </filesystem>
+    <filesystem type='mount' accessmode='mapped'>
+      <source dir='%s'/>
+      <target dir='home'/>
+    </filesystem>
+  </devices>
+  <qemu:commandline>
+    <qemu:arg value='-device'/>
+    <qemu:arg value='e1000,netdev=net0'/>
+    <qemu:arg value='-netdev'/>
+    <qemu:arg value='user,id=net0'/>
+    <qemu:arg value='-snapshot'/>
+  </qemu:commandline>
+</domain>
+`