From 8f4e456bb2405579f678178904088417ba4ce932 Mon Sep 17 00:00:00 2001 From: juacq97 Date: Sun, 24 Mar 2019 16:00:51 -0700 Subject: [PATCH 1/3] make the script POSIX compliant --- user-scripts/kdeconnect | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/user-scripts/kdeconnect b/user-scripts/kdeconnect index d34d269f..5b469529 100755 --- a/user-scripts/kdeconnect +++ b/user-scripts/kdeconnect @@ -6,11 +6,11 @@ # Author: juacq97 id=$(kdeconnect-cli -a --id-only | awk '{print $1}') -if [ $(find ~/.nnncp) ] +if [ "$(find ~/.nnncp)" ] then - kdeconnect-cli -d $id --share $(cat ~/.nnncp) + kdeconnect-cli -d "$id" --share "$(cat ~/.nnncp)" # If you want a system notification, uncomment the next 3 lines. -# notify-send -a "Kdeconnect" "Sending $(cat ~/.nnncp)" -#else -# notify-send -a "Kdeconnect" "No file selected" + notify-send -a "Kdeconnect" "Sending $(cat ~/.nnncp)" +else + notify-send -a "Kdeconnect" "No file selected" fi From 21e259ecd491f62ab2971c3f7ae533ae82cb86dc Mon Sep 17 00:00:00 2001 From: juacq97 Date: Sun, 24 Mar 2019 22:29:37 -0700 Subject: [PATCH 2/3] Changed the Shell type to POSIX compliant --- user-scripts/kdeconnect | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/user-scripts/kdeconnect b/user-scripts/kdeconnect index 5b469529..56d6d069 100755 --- a/user-scripts/kdeconnect +++ b/user-scripts/kdeconnect @@ -1,13 +1,12 @@ -#!/bin/sh +#!/usr/bin/env sh # Description: Send the selected files to your Android device using kdeconnect-cli. You must have installed and configured kdeconnect both on the Android device and on the PC. # -# Shell: Bash +# Shell: POSIX compliant # Author: juacq97 id=$(kdeconnect-cli -a --id-only | awk '{print $1}') -if [ "$(find ~/.nnncp)" ] -then +if [ "$(find ~/.nnncp)" ]; then kdeconnect-cli -d "$id" --share "$(cat ~/.nnncp)" # If you want a system notification, uncomment the next 3 lines. notify-send -a "Kdeconnect" "Sending $(cat ~/.nnncp)" From 3b4be9fad356b7ae767df6d016ebdf7bbf744f3d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juan=20Adri=C3=A1n=20Castro=20Quintana?= Date: Sun, 24 Mar 2019 23:24:34 -0700 Subject: [PATCH 3/3] Deleted blank line Also, I commented again the three lines about the notifications. --- user-scripts/kdeconnect | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/user-scripts/kdeconnect b/user-scripts/kdeconnect index 0a3f3a25..0fbafbbd 100755 --- a/user-scripts/kdeconnect +++ b/user-scripts/kdeconnect @@ -3,14 +3,13 @@ # Description: Send the selected files to your Android device using kdeconnect-cli. You must have installed and configured kdeconnect both on the Android device and on the PC. # # Shell: POSIX compliant - # Author: juacq97 id=$(kdeconnect-cli -a --id-only | awk '{print $1}') if [ "$(find ~/.nnncp)" ]; then kdeconnect-cli -d "$id" --share "$(cat ~/.nnncp)" # If you want a system notification, uncomment the next 3 lines. - notify-send -a "Kdeconnect" "Sending $(cat ~/.nnncp)" -else - notify-send -a "Kdeconnect" "No file selected" +# notify-send -a "Kdeconnect" "Sending $(cat ~/.nnncp)" +#else +# notify-send -a "Kdeconnect" "No file selected" fi