From 0aefc2f4962a89b7a7731583862416871afeacd7 Mon Sep 17 00:00:00 2001 From: lostd Date: Wed, 28 Jan 2015 12:47:11 +0200 Subject: [PATCH] Change scope to always check the correct return value --- noice.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/noice.c b/noice.c index 63002cf9..80be09f0 100644 --- a/noice.c +++ b/noice.c @@ -748,15 +748,16 @@ moretyping: if (r == 1) nowtyping = 0; /* Check regex errors */ - if (tmp != NULL) + if (tmp != NULL) { r = setfilter(&re, tmp); - if (r != 0) - if (nowtyping) { - goto moretyping; - } else { - free(tmp); - goto nochange; - } + if (r != 0) + if (nowtyping) { + goto moretyping; + } else { + free(tmp); + goto nochange; + } + } /* Copy or reset filter */ free(filter); if (tmp != NULL)