From ff27d9ee14d533bee6d6d3a131acd769d8c157b3 Mon Sep 17 00:00:00 2001 From: NRK Date: Wed, 26 Oct 2022 14:54:07 +0600 Subject: [PATCH 1/3] clarify the goal of the default icon set --- src/icons.h | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/src/icons.h b/src/icons.h index fe53980f..846b77a5 100644 --- a/src/icons.h +++ b/src/icons.h @@ -195,9 +195,16 @@ static const struct icon_pair icons_name[] = { #ifdef ICONS_GENERATE /* - * All entries are case-insensitive + * The goal here is to provide a small set of default values. We don't try to + * provide icons for everything under the sun because keeping a _huge_ table of + * icons would: increase binary size, increase memory usage, decrease performance. + * + * Users are free to customize this *locally* as they see fit. Only open a + * pull-request if you think your changes are aligned with the goal described + * above. */ -static const struct icon_pair icons_ext[] = { + +static const struct icon_pair icons_ext[] = { /* All entries are case-insensitive */ /* Numbers */ {"1", ICON_MANUAL, COLOR_DOCS}, {"7z", ICON_ARCHIVE, COLOR_ARCHIVE}, From 080a0619694b81ac5b2efaac63c985b0040963e3 Mon Sep 17 00:00:00 2001 From: NRK Date: Wed, 26 Oct 2022 14:55:20 +0600 Subject: [PATCH 2/3] icons.h: fix alignment --- src/icons.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/icons.h b/src/icons.h index 846b77a5..51073d67 100644 --- a/src/icons.h +++ b/src/icons.h @@ -356,10 +356,10 @@ static const struct icon_pair icons_ext[] = { /* All entries are case-insensitiv {"pptx", ICON_POWERPOINT, 0}, {"psb", ICON_PHOTOSHOP, 0}, {"psd", ICON_PHOTOSHOP, 0}, - {"py", ICON_PYTHON, COLOR_PYTHON}, - {"pyc", ICON_PYTHON, COLOR_PYTHON}, - {"pyd", ICON_PYTHON, COLOR_PYTHON}, - {"pyo", ICON_PYTHON, COLOR_PYTHON}, + {"py", ICON_PYTHON, COLOR_PYTHON}, + {"pyc", ICON_PYTHON, COLOR_PYTHON}, + {"pyd", ICON_PYTHON, COLOR_PYTHON}, + {"pyo", ICON_PYTHON, COLOR_PYTHON}, /* Q */ @@ -391,7 +391,7 @@ static const struct icon_pair icons_ext[] = { /* All entries are case-insensitiv {"tar", ICON_ARCHIVE, COLOR_ARCHIVE}, {"tex", ICON_TEX, 0}, {"tgz", ICON_ARCHIVE, COLOR_ARCHIVE}, - {"ts", ICON_EXT_TS, COLOR_JAVASCRIPT}, + {"ts", ICON_EXT_TS, COLOR_JAVASCRIPT}, {"tsx", ICON_REACT, COLOR_REACT}, {"txt", ICON_DOCUMENT, COLOR_DOCUMENT}, {"txz", ICON_ARCHIVE, COLOR_ARCHIVE}, From 985f6537ce7c017f9cc9a6d8c580a9a3c13d24ec Mon Sep 17 00:00:00 2001 From: NRK Date: Wed, 26 Oct 2022 15:08:27 +0600 Subject: [PATCH 3/3] add ksh, ttf and otf icons Co-authored-by: Tanner Babcock --- src/icons.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/icons.h b/src/icons.h index 51073d67..5cefe4d3 100644 --- a/src/icons.h +++ b/src/icons.h @@ -68,6 +68,7 @@ #define ICON_ELIXIR ICON_STR(MFIZZ_ELIXIR, "\ue62d", "💧") #define ICON_ENCRYPT ICON_STR("", "\uf805", "🔒") #define ICON_FSHARP ICON_STR(DEV_FSHARP, "\ue7a7", "") +#define ICON_FONT ICON_STR(FILE_FONT, "\uf031", "") #define ICON_GIT ICON_STR(FA_GIT, "\ue5fb", "🌱") #define ICON_HASKELL ICON_STR("", "\ue777", "") #define ICON_HTML ICON_STR(FA_FILE_CODE_O, "\uf72d", "") @@ -310,6 +311,7 @@ static const struct icon_pair icons_ext[] = { /* All entries are case-insensitiv {"jsx", ICON_REACT, COLOR_REACT}, /* K */ + {"ksh", ICON_SCRIPT, COLOR_SHELL}, /* L */ {"lha", ICON_ARCHIVE, COLOR_ARCHIVE}, @@ -343,6 +345,7 @@ static const struct icon_pair icons_ext[] = { /* All entries are case-insensitiv {"ogg", ICON_MUSICFILE, COLOR_AUDIO}, {"opus", ICON_MUSICFILE, COLOR_AUDIO}, {"opdownload", ICON_DOWNLOADS, 0}, + {"otf", ICON_FONT, 0}, {"out", ICON_LINUX, 0}, /* P */ @@ -395,6 +398,7 @@ static const struct icon_pair icons_ext[] = { /* All entries are case-insensitiv {"tsx", ICON_REACT, COLOR_REACT}, {"txt", ICON_DOCUMENT, COLOR_DOCUMENT}, {"txz", ICON_ARCHIVE, COLOR_ARCHIVE}, + {"ttf", ICON_FONT, 0}, /* U */