From 35f3b250bb1e218a46da9e6287f31fb5aeaa3f62 Mon Sep 17 00:00:00 2001 From: sin Date: Wed, 22 Oct 2014 15:05:14 +0100 Subject: [PATCH] Only free() after xstrdup() --- noice.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/noice.c b/noice.c index e804e686..37cc91db 100644 --- a/noice.c +++ b/noice.c @@ -128,12 +128,11 @@ xdirname(const char *path) * original string if we lose track of it. */ tmp = xstrdup(path); p = dirname(tmp); - free(tmp); if (p == NULL) printerr(1, "dirname"); - /* Make sure this is a malloc(3)-ed string */ p = xstrdup(p); + free(tmp); return p; }