From 4f905ecb9636561d91bc9b33919cd390bdcbc432 Mon Sep 17 00:00:00 2001 From: Mykyta Holubakha Date: Sat, 1 Jul 2017 20:21:12 +0300 Subject: [PATCH 1/2] permit.c: check for NULL pointer dereference --- sway/commands/permit.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sway/commands/permit.c b/sway/commands/permit.c index 66fa4e2a..7a5e06f7 100644 --- a/sway/commands/permit.c +++ b/sway/commands/permit.c @@ -65,11 +65,11 @@ struct cmd_results *cmd_permit(int argc, char **argv) { } struct feature_policy *policy = get_feature_policy(program); - if (assign_perms) { + if (policy && assign_perms) { policy->features |= get_features(argc, argv, &error); + sway_log(L_DEBUG, "Permissions granted to %s for features %d", + policy->program, policy->features); } - sway_log(L_DEBUG, "Permissions granted to %s for features %d", - policy->program, policy->features); free(program); return cmd_results_new(CMD_SUCCESS, NULL, NULL); From 7d8a84b58790454308bcac114d3f28a09c28928c Mon Sep 17 00:00:00 2001 From: Mykyta Holubakha Date: Sat, 1 Jul 2017 20:30:38 +0300 Subject: [PATCH 2/2] Do not add empty policies Policy allocation failure is non-fatal --- sway/commands.c | 6 +++--- sway/security.c | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/sway/commands.c b/sway/commands.c index 14be656a..d55d9a96 100644 --- a/sway/commands.c +++ b/sway/commands.c @@ -608,10 +608,10 @@ struct cmd_results *config_commands_command(char *exec) { } if (!policy) { policy = alloc_command_policy(cmd); - if (!policy) { - sway_abort("Unable to allocate security policy"); + sway_assert(policy, "Unable to allocate security policy"); + if (policy) { + list_add(config->command_policies, policy); } - list_add(config->command_policies, policy); } policy->context = context; diff --git a/sway/security.c b/sway/security.c index 92de06c1..fcd70f9d 100644 --- a/sway/security.c +++ b/sway/security.c @@ -152,10 +152,10 @@ struct feature_policy *get_feature_policy(const char *name) { } if (!policy) { policy = alloc_feature_policy(name); - if (!policy) { - sway_abort("Unable to allocate security policy"); + sway_assert(policy, "Unable to allocate security policy"); + if (policy) { + list_add(config->feature_policies, policy); } - list_add(config->feature_policies, policy); } return policy; }