From e2efe599aa9d7925c96d5e801acb901304a307fd Mon Sep 17 00:00:00 2001 From: felix Date: Sun, 2 May 2021 11:10:35 +0200 Subject: [PATCH] [common] Fix FourCC fallback when parsing ISM (#372) In some DASH manifests, the FourCC attribute is actually present, but empty. We thus apply the same fallback to 'AACL' that we do when the attribute is entirely absent. Authored by: fstirlitz --- yt_dlp/extractor/common.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/yt_dlp/extractor/common.py b/yt_dlp/extractor/common.py index 2e4f3559a..64ab8f706 100644 --- a/yt_dlp/extractor/common.py +++ b/yt_dlp/extractor/common.py @@ -2876,7 +2876,7 @@ def _parse_ism_formats_and_subtitles(self, ism_doc, ism_url, ism_id=None): stream_name = stream.get('Name') stream_language = stream.get('Language', 'und') for track in stream.findall('QualityLevel'): - fourcc = track.get('FourCC', 'AACL' if track.get('AudioTag') == '255' else None) + fourcc = track.get('FourCC') or ('AACL' if track.get('AudioTag') == '255' else None) # TODO: add support for WVC1 and WMAP if fourcc not in ('H264', 'AVC1', 'AACL', 'TTML'): self.report_warning('%s is not a supported codec' % fourcc)