lpnf
/
lovr
mirror of https://github.com/bjornbytes/lovr.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Fix issues with Pass buffer recycling; 

- When destroyed, Pass should only recycle its buffer if it actually has one.
- When resetting, chain all of the buffers at once instead of one-by-one (N^2)
This commit is contained in:
bjorn 2024-02-08 11:32:01 -08:00
parent df3544e5f3
commit bf97a55fcb
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/modules/graphics/graphics.c
View File

@ -5035,12 +5035,14 @@ static BufferView lovrPassGetBuffer(Pass* pass, uint32_t size, size_t align) {
}
static void lovrPassRelease(Pass* pass) {
for (BufferBlock* block = pass->buffers.freelist; block; block = block->next) {
freeBlock(&state.bufferAllocators[GPU_BUFFER_STREAM], block);
// Chain all of the Pass's full buffers onto the end of the global freelist
if (pass->buffers.freelist) {
BufferBlock** list = &state.bufferAllocators[GPU_BUFFER_STREAM].freelist;
while (*list) list = (BufferBlock**) &(*list)->next;
*list = pass->buffers.freelist;
pass->buffers.freelist = NULL;
}
pass->buffers.freelist = NULL;
if (pass->pipeline) {
for (uint32_t i = 0; i <= pass->pipelineIndex; i++) {
lovrRelease(pass->pipeline->material, lovrMaterialDestroy);
@ -5120,7 +5122,7 @@ void lovrPassDestroy(void* ref) {
gpu_tally_destroy(pass->tally.gpu);
lovrRelease(pass->tally.tempBuffer, lovrBufferDestroy);
}
freeBlock(&state.bufferAllocators[GPU_BUFFER_STREAM], pass->buffers.current);
if (pass->buffers.current) freeBlock(&state.bufferAllocators[GPU_BUFFER_STREAM], pass->buffers.current);
os_vm_free(pass->allocator.memory, pass->allocator.limit);
free(pass);
}