Free objects in their destructors;

This commit is contained in:
bjorn 2019-04-05 03:56:10 -07:00
parent ae470d8804
commit d31dca5520
21 changed files with 29 additions and 4 deletions

View File

@ -16,6 +16,7 @@ void lovrMicrophoneDestroy(void* ref) {
Microphone* microphone = ref;
lovrMicrophoneStopRecording(microphone);
alcCaptureCloseDevice(microphone->device);
free(microphone);
}
int lovrMicrophoneGetBitDepth(Microphone* microphone) {

View File

@ -37,6 +37,7 @@ void lovrSourceDestroy(void* ref) {
alDeleteBuffers(source->type == SOURCE_STATIC ? 1 : SOURCE_BUFFERS, source->buffers);
lovrRelease(SoundData, source->soundData);
lovrRelease(AudioStream, source->stream);
free(source);
}
SourceType lovrSourceGetType(Source* source) {

View File

@ -28,6 +28,7 @@ void lovrAudioStreamDestroy(void* ref) {
stb_vorbis_close(stream->decoder);
lovrRelease(Blob, stream->blob);
free(stream->buffer);
free(stream);
}
int lovrAudioStreamDecode(AudioStream* stream, short* destination, int size) {

View File

@ -10,4 +10,5 @@ Blob* lovrBlobInit(Blob* blob, void* data, size_t size, const char* name) {
void lovrBlobDestroy(void* ref) {
Blob* blob = ref;
free(blob->data);
free(blob);
}

View File

@ -20,6 +20,7 @@ void lovrModelDataDestroy(void* ref) {
lovrRelease(TextureData, model->textures[i]);
}
free(model->data);
free(model);
}
// Note: this code is a scary optimization

View File

@ -34,6 +34,7 @@ Rasterizer* lovrRasterizerInit(Rasterizer* rasterizer, Blob* blob, float size) {
void lovrRasterizerDestroy(void* ref) {
Rasterizer* rasterizer = ref;
lovrRelease(Blob, rasterizer->blob);
free(rasterizer);
}
bool lovrRasterizerHasGlyph(Rasterizer* rasterizer, uint32_t character) {

View File

@ -12,6 +12,7 @@ void lovrFileDestroy(void* ref) {
if (file->handle) {
PHYSFS_close(file->handle);
}
free(file);
}
int lovrFileOpen(File* file, FileMode mode) {

View File

@ -36,6 +36,7 @@ void lovrAnimatorDestroy(void* ref) {
Animator* animator = ref;
lovrRelease(ModelData, animator->data);
vec_deinit(&animator->tracks);
free(animator);
}
void lovrAnimatorReset(Animator* animator) {

View File

@ -61,6 +61,7 @@ void lovrFontDestroy(void* ref) {
}
map_deinit(&font->atlas.glyphs);
map_deinit(&font->kerning);
free(font);
}
Rasterizer* lovrFontGetRasterizer(Font* font) {

View File

@ -27,6 +27,7 @@ void lovrMaterialDestroy(void* ref) {
for (int i = 0; i < MAX_MATERIAL_TEXTURES; i++) {
lovrRelease(Texture, material->textures[i]);
}
free(material);
}
void lovrMaterialBind(Material* material, Shader* shader) {

View File

@ -193,6 +193,7 @@ void lovrModelDestroy(void* ref) {
lovrRelease(Mesh, model->meshes[i]);
}
lovrRelease(ModelData, model->data);
free(model);
}
void lovrModelDraw(Model* model, mat4 transform, int instances) {

View File

@ -1241,6 +1241,7 @@ void lovrTextureDestroy(void* ref) {
glDeleteTextures(1, &texture->id);
glDeleteRenderbuffers(1, &texture->msaaId);
lovrGpuDestroySyncResource(texture, texture->incoherent);
free(texture);
}
void lovrTextureAllocate(Texture* texture, int width, int height, int depth, TextureFormat format) {
@ -1485,6 +1486,7 @@ void lovrCanvasDestroy(void* ref) {
lovrRelease(Texture, canvas->attachments[i].texture);
}
lovrRelease(Texture, canvas->depth.texture);
free(canvas);
}
void lovrCanvasResolve(Canvas* canvas) {
@ -1597,6 +1599,7 @@ void lovrBufferDestroy(void* ref) {
#ifndef LOVR_WEBGL
}
#endif
free(buffer);
}
void* lovrBufferMap(Buffer* buffer, size_t offset) {
@ -1961,6 +1964,7 @@ void lovrShaderDestroy(void* ref) {
map_deinit(&shader->attributes);
map_deinit(&shader->uniformMap);
map_deinit(&shader->blockMap);
free(shader);
}
// Mesh
@ -1987,6 +1991,7 @@ void lovrMeshDestroy(void* ref) {
lovrRelease(Buffer, mesh->vertexBuffer);
lovrRelease(Buffer, mesh->indexBuffer);
lovrRelease(Material, mesh->material);
free(mesh);
}
void lovrMeshSetIndexBuffer(Mesh* mesh, Buffer* buffer, uint32_t indexCount, size_t indexSize, size_t offset) {

View File

@ -198,6 +198,7 @@ void lovrShaderBlockDestroy(void* ref) {
lovrRelease(Buffer, block->buffer);
vec_deinit(&block->uniforms);
map_deinit(&block->uniformMap);
free(block);
}
BlockType lovrShaderBlockGetType(ShaderBlock* block) {

View File

@ -51,5 +51,5 @@ void lovrHeadsetDestroy() {
}
void lovrControllerDestroy(void* ref) {
//
free(ref);
}

View File

@ -46,6 +46,7 @@ Curve* lovrCurveInit(Curve* curve, int sizeHint) {
void lovrCurveDestroy(void* ref) {
Curve* curve = ref;
vec_deinit(&curve->points);
free(curve);
}
void lovrCurveEvaluate(Curve* curve, float t, vec3 p) {

View File

@ -18,6 +18,7 @@ Pool* lovrPoolInit(Pool* pool, size_t size) {
void lovrPoolDestroy(void* ref) {
Pool* pool = ref;
free(pool->data);
free(pool);
}
float* lovrPoolAllocate(Pool* pool, MathType type) {

View File

@ -29,7 +29,7 @@ RandomGenerator* lovrRandomGeneratorInit(RandomGenerator* generator) {
}
void lovrRandomGeneratorDestroy(void* ref) {
//
free(ref);
}
Seed lovrRandomGeneratorGetSeed(RandomGenerator* generator) {

View File

@ -68,6 +68,7 @@ void lovrWorldDestroy(void* ref) {
lovrWorldDestroyData(world);
vec_deinit(&world->overlaps);
map_deinit(&world->tags);
free(world);
}
void lovrWorldDestroyData(World* world) {
@ -300,6 +301,7 @@ void lovrColliderDestroy(void* ref) {
lovrColliderDestroyData(collider);
vec_deinit(&collider->shapes);
vec_deinit(&collider->joints);
free(collider);
}
void lovrColliderDestroyData(Collider* collider) {
@ -662,6 +664,7 @@ void lovrColliderGetAABB(Collider* collider, float aabb[6]) {
void lovrShapeDestroy(void* ref) {
Shape* shape = ref;
lovrShapeDestroyData(shape);
free(shape);
}
void lovrShapeDestroyData(Shape* shape) {
@ -871,6 +874,7 @@ void lovrCylinderShapeSetLength(CylinderShape* cylinder, float length) {
void lovrJointDestroy(void* ref) {
Joint* joint = ref;
lovrJointDestroyData(joint);
free(joint);
}
void lovrJointDestroyData(Joint* joint) {

View File

@ -15,6 +15,7 @@ void lovrChannelDestroy(void* ref) {
vec_deinit(&channel->messages);
mtx_destroy(&channel->lock);
cnd_destroy(&channel->cond);
free(channel);
}
bool lovrChannelPush(Channel* channel, Variant variant, double timeout, uint64_t* id) {

View File

@ -47,6 +47,7 @@ void lovrThreadDestroy(void* ref) {
Thread* thread = ref;
mtx_destroy(&thread->lock);
thrd_detach(thread->handle);
free(thread);
}
void lovrThreadStart(Thread* thread) {

View File

@ -110,5 +110,5 @@ uint32_t nextPo2(uint32_t x);
#define lovrAssert(c, ...) if (!(c)) { lovrThrow(__VA_ARGS__); }
#define lovrAlloc(T) (T*) _lovrAlloc(sizeof(T), T_ ## T)
#define lovrRetain(r) if (r && ++(((Ref*) r)->count) >= 0xff) lovrThrow("Ref count overflow")
#define lovrRelease(T, r) if (r && --(((Ref*) r)->count) == 0) lovr ## T ## Destroy(r), free(r)
#define lovrGenericRelease(r) if (r && --(((Ref*) r)->count) == 0) lovrTypeInfo[((Ref*) r)->type].destructor(r), free(r)
#define lovrRelease(T, r) if (r && --(((Ref*) r)->count) == 0) lovr ## T ## Destroy(r)
#define lovrGenericRelease(r) if (r && --(((Ref*) r)->count) == 0) lovrTypeInfo[((Ref*) r)->type].destructor(r)