browse: fix nnn -e (#549)

The current code will start editor if the mime doesn't start with
"text/". But, we want the opposite.

Simplify the check by using `strncmp` instead.

We may improve by writing a helper: `start_withs` in the future.

This change also cleans -Wstrict-aliasing on Ubuntu 16.04 LTS
This commit is contained in:
Danh Doan 2020-05-03 04:26:16 +00:00 committed by GitHub
parent ff568ea748
commit e8e87f6ba2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -5404,7 +5404,7 @@ nochange:
if (cfg.useeditor && (!sb.st_size || if (cfg.useeditor && (!sb.st_size ||
#ifdef FILE_MIME_OPTS #ifdef FILE_MIME_OPTS
(get_output(g_buf, CMD_LEN_MAX, "file", FILE_MIME_OPTS, newpath, FALSE) (get_output(g_buf, CMD_LEN_MAX, "file", FILE_MIME_OPTS, newpath, FALSE)
&& !(((int *)g_buf)[0] == *(int *)"text" && g_buf[4] == '/')))) { && !strncmp(g_buf, "text/", 5)))) {
#else #else
/* no mime option; guess from description instead */ /* no mime option; guess from description instead */
(get_output(g_buf, CMD_LEN_MAX, "file", "-b", newpath, FALSE) (get_output(g_buf, CMD_LEN_MAX, "file", "-b", newpath, FALSE)