mirrors/nnn
1
0
Fork 0
mirror of https://github.com/jarun/nnn.git synced 2025-01-15 21:36:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

icons-hash: fix bitwise rotation

Browse source 
in case the rotation is 0, `v >> (32 - r)` would end up doing a 32 right
shift which is equal to the width of `v` and thus undefined behavior.

ref: https://blog.regehr.org/archives/1063
This commit is contained in:
NRK 2023-01-03 02:20:21 +06:00
parent c9b384f009
commit fb5b2e5e64
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/icons-hash.c
View file

@ -109,7 +109,7 @@ pcg(uint64_t *state)
*state *= GOLDEN_RATIO_64; *state *= GOLDEN_RATIO_64;
uint32_t r = (oldstate >> 59); uint32_t r = (oldstate >> 59);
uint32_t v = (oldstate ^ (oldstate >> 18)) >> 27; uint32_t v = (oldstate ^ (oldstate >> 18)) >> 27;
return (v >> (32 - r)) | (v << r); return (v >> (-r & 31)) | (v << r);
} }
int int