Commit graph

4303 commits

Author SHA1 Message Date
Arun Prakash Jana 4f95796ede
Run cmd as plugin now supported exported variables 2023-01-28 10:01:46 +05:30
Arun Prakash Jana b80e047d50
Set defaults for some multiple choice prompts
Archive options: listing
Create new options: create file
Open with options: command type GUI
2023-01-28 09:50:58 +05:30
Arun Prakash Jana ad4ecb19cb
Simplify paged and GUI commands run as plugin 2023-01-28 09:16:06 +05:30
Arun Prakash Jana 03e0531e81
Place "$nnn" in double quotes in man page examples 2023-01-28 08:31:25 +05:30
Arun 786ecf9fc2
Merge pull request #1571 from KlzXS/plugin_simplification
Simplify the command as plugin codepath
2023-01-28 08:23:24 +05:30
Arun 1a5a7da8eb
Merge pull request #1570 from KlzXS/general_simplification
Second attempt at #1566
2023-01-28 08:22:52 +05:30
Arun d4575e99c8
Merge pull request #1573 from N-R-K/fix_chksum
plugins/chksum: use exit instead of return
2023-01-27 21:03:45 +05:30
NRK ca8fcf454a plugins/chksum: use exit instead of return
From https://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_24:

| The return utility shall cause the shell to stop executing the current
| function or dot script. If the shell is not currently executing a
| function or dot script, the results are unspecified.

Closes: https://github.com/jarun/nnn/issues/1572
2023-01-26 01:21:40 +06:00
KlzXS 867726d870
Add debug message for bad call 2023-01-25 18:56:48 +01:00
KlzXS 7abfb77a13
Update signatures 2023-01-25 17:37:31 +01:00
KlzXS 827e84a56f
Simplify commands as plugins
Remove restrictions on $nnn

Update the plugin README
2023-01-25 17:33:15 +01:00
KlzXS 8d21e5e832
Revert using UTIL_SH_EXEC 2023-01-25 17:26:14 +01:00
Arun Prakash Jana 6b94911bc9 Revert "Simplify get_output()"
This reverts commit 6c23fdfd5f.
2023-01-16 00:19:03 +05:30
Arun Prakash Jana 653cab9dff Revert "Give better names to variables"
This reverts commit 1a2f783b75.
2023-01-16 00:18:52 +05:30
Arun Prakash Jana f9295780ef Revert "Make CI happy"
This reverts commit 8a1e32d9eb.
2023-01-16 00:18:41 +05:30
Arun Prakash Jana cac5b9ba33 Revert "Concatenate arguments to pass to sh"
This reverts commit 428c652d36.
2023-01-16 00:18:19 +05:30
Arun Prakash Jana df05f593de Revert "Paging is achieved through shell command now"
This reverts commit 243301603e.
2023-01-16 00:15:54 +05:30
Arun Prakash Jana 243301603e
Paging is achieved through shell command now 2023-01-15 11:46:03 +05:30
Arun f9281c8eab
Merge pull request #1566 from KlzXS/general_simplification
General simplification
2023-01-15 11:16:01 +05:30
Arun 428c652d36
Concatenate arguments to pass to sh
Co-authored-by: KlzXS <klzx+github@klzx.cf>
Co-authored-by: Arun Prakash Jana <engineerarun@gmail.com>
2023-01-15 10:59:36 +05:30
KlzXS 8a1e32d9eb
Make CI happy 2023-01-14 23:18:22 +01:00
KlzXS 1a2f783b75
Give better names to variables 2023-01-14 22:31:16 +01:00
KlzXS 6c23fdfd5f
Simplify get_output() 2023-01-14 22:11:10 +01:00
Arun fef3c673cd
Merge pull request #1565 from N-R-K/discussion_template
issue-template: add a section for opening a discussion
2023-01-14 18:35:59 +05:30
NRK 1887cd1a77 issue-template: add a section for opening a discussion
this should give the section more visibility.
2023-01-14 18:48:11 +06:00
Arun 12aedd521d
Merge pull request #1563 from N-R-K/macos_ci
attempt at fixing macos CI
2023-01-10 20:59:49 +05:30
NRK cf68675478 attempt at fixing macos CI 2023-01-10 14:19:00 +06:00
Arun 2b6fb3f388
Merge pull request #1559 from leovilok/tabbed-wayland-warn
preview-tabbed: warn & prevent running on Wayland
2023-01-08 06:32:50 +05:30
Léo Villeveygoux dac5fb0af9 preview-tabbed: warn & prevent running on Wayland 2023-01-07 23:19:28 +01:00
Arun Prakash Jana 789449a464 Update bug template 2023-01-06 04:24:38 +05:30
Arun fa62b08243
Merge pull request #1555 from N-R-K/icons_fix_ub
icons-hash: fix bitwise rotation
2023-01-03 04:38:26 +05:30
Arun Prakash Jana dd214c50f3
Update plugin docs and examples 2023-01-03 04:37:07 +05:30
NRK fb5b2e5e64 icons-hash: fix bitwise rotation
in case the rotation is 0, `v >> (32 - r)` would end up doing a 32 right
shift which is equal to the width of `v` and thus undefined behavior.

ref: https://blog.regehr.org/archives/1063
2023-01-03 02:20:21 +06:00
Raffaele Mancuso c9b384f009
[kdeconnect] Various improvements (#1551)
- Support multiple devices paired and available at the same time
- Filter out non-regular files
2023-01-02 22:23:47 +05:30
N-R-K 2000ed5080
icons-hash: misc improvements (#1553)
* icons-hash: take total probe count into account as well

* icons-hash: use a better PRNG

the older method was using a multiplicative congruential generator (MCG)
which doesn't work too well especially with just 32 bits of state.

change it to a PCG instead with 64 bits of state (and 32 bits of output)
which should give better results.

and since we should get better rng - the search iteration has been
halved as well to save some build time.

* icons-hash: use an xor-rotate hash function

* icons-hash: fix some compiler warnings
2023-01-02 22:23:18 +05:30
8B411 a51437ff16
Miscellaneous improvements to nmount plugin (#1547)
* plugins/nmount: keep `while` & `do` on one line for consistency

* plugins/nmount: sync only that device, which user wants to unmount

* plugins/nmount: replace all instances of `$dev` with `/dev/$dev`

* plugins/nmount: add `--no-user-interaction` option to `udisksctl`

Otherwise the user will be asked for authentication each time he wants
to unmount, say, HDD, since `udisksctl` will try to power it off.

* plugins/nmount: try to mount only existing block devices

* plugins/nmount: do not invoke `lsblk` immediately after mounting

Sometimes `lsblk` fails to provide mountpoint in such a short time frame.

* plugins/nmount: simplify pipe

* plugins/nmount: keep `echo` arguments in a single pair of quotes

* plugins/nmount: report mountpoint only if mounting was successful
2022-12-21 23:14:28 +05:30
Arun Prakash Jana e236bd0b3a
Add Discussions link to README. 2022-12-18 21:30:23 +05:30
Raffaele Mancuso 1b5cfbca3d
kdeconnect: misc improvements (#1543)
- Work with multiple connected devices by sending files to the first
  device
- Support multi-files selection
- Support sending hovered file in case no file is selected

Co-authored-by: NRK <nrk@disroot.org>
Co-authored-by: Arun Prakash Jana <engineerarun@gmail.com>
2022-12-18 21:29:52 +05:30
Arun Prakash Jana 1688b07d0e
Update readme 2022-12-16 19:54:53 +05:30
Arun 4d54490433
Merge pull request #1542 from KlzXS/archive_script
Remove unnecessary parameter from `archive_selection()`
2022-12-13 18:40:42 +05:30
KlzXS 87627a6e08
Remove unnecessary parameter from archive_selection() 2022-12-12 16:13:35 +01:00
Arun Prakash Jana 17ed380b57
Optimize link creation 2022-12-12 18:03:11 +05:30
Arun Prakash Jana 38d7090e64
Clear selection if all links are generated 2022-12-12 16:15:06 +05:30
Arun Prakash Jana 824e7a2c18
Show errno on link creation failure 2022-12-12 15:57:20 +05:30
Arun Prakash Jana 2e84716e76
Restore check to prevent overwriting hovered file when archiving 2022-12-12 14:45:04 +05:30
Arun Prakash Jana e8bc59a816
Improve archive, rename, new workflows
1. hover on entry created in cwd
2. check user input doesn't end with /
3. check user input len < PATH_MAX
4. support creation in ~ directory
5. handle filter mode after creation
6. ensure absolute path len < PATH_MAX
2022-12-12 10:19:53 +05:30
Arun Prakash Jana 32a6a63f44
Improve archive creation handling 2022-12-12 02:43:23 +05:30
Arun Prakash Jana cf46da60d9
Fix memory leak 2022-12-12 00:17:28 +05:30
Arun Prakash Jana 1a04e813be
Update docs 2022-12-11 10:53:16 +05:30
Arun Prakash Jana 02dec98bf8
Use built-in 2022-12-11 03:42:34 +05:30