mirrors/sway
1
0
Fork 0
mirror of https://github.com/swaywm/sway.git synced 2024-11-22 16:01:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

view: check if the buffer was uploaded on save

Browse source 
wlr_surface_has_buffer() is insufficient; if a client has committed a
buffer but it couldn't be applied, NULL deref happens in the next line.
This commit is contained in:
Kirill Primak 2023-10-24 15:24:51 +03:00 committed by Simon Ser
parent 0dfaf7ea63
commit 47263aca28
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
sway/tree/view.c
View file

@ -1422,7 +1422,7 @@ static void view_save_buffer_iterator(struct wlr_surface *surface,
int sx, int sy, void *data) { int sx, int sy, void *data) {
struct sway_view *view = data; struct sway_view *view = data;
if (surface && wlr_surface_has_buffer(surface)) { if (surface && surface->buffer) {
wlr_buffer_lock(&surface->buffer->base); wlr_buffer_lock(&surface->buffer->base);
struct sway_saved_buffer *saved_buffer = calloc(1, sizeof(struct sway_saved_buffer)); struct sway_saved_buffer *saved_buffer = calloc(1, sizeof(struct sway_saved_buffer));
saved_buffer->buffer = surface->buffer; saved_buffer->buffer = surface->buffer;