mirrors/sway
1
0
Fork 0
mirror of https://github.com/swaywm/sway.git synced 2024-11-24 08:51:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

commands/move: Focus inactive view when no parent is found

Browse source 
There are some cases where the inactive view is the null container that wraps
tabbed and stacking layouts. The following demonstrates how this results
in some unexpected behavior:

1. On an empty workspace, spawn three windows.
2. Convert the layout to stacking with `layout stacking`.
3. Toggle one of the windows as floating with `toggle floating`.
4. With the floating window still selected, move it to another workspace with
   `move container to workspace`.

We'd expect just one window to be selected instead of all remaining windows in
the workspace. We can fix this by selecting the inactive view instead.
This commit is contained in:
Ankit Pandey 2024-06-11 17:55:29 -07:00
parent cc34210769
commit 81d1ed13e1
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
sway/commands/move.c
View file

@ -601,7 +601,9 @@ static struct cmd_results *cmd_move_container(bool no_auto_back_and_forth,
focus = seat_get_focus_inactive(seat, &old_parent->node); focus = seat_get_focus_inactive(seat, &old_parent->node);
} }
if (!focus && old_ws) { if (!focus && old_ws) {
focus = seat_get_focus_inactive(seat, &old_ws->node); struct sway_container *container =
seat_get_focus_inactive_view(seat, &old_ws->node);
focus = &container->node;
} }
} }
seat_set_focus(seat, focus); seat_set_focus(seat, focus);