mirrors/sway
1
0
Fork 0
mirror of https://github.com/swaywm/sway.git synced 2024-09-30 22:52:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

fixed small memory leak. v2

Browse source
This commit is contained in:
Taiyu 2015-08-10 13:16:38 -07:00
parent 54374d81b5
commit 820dda1be6
1 changed files with 18 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
sway/commands.c
View file

@ -346,9 +346,10 @@ struct cmd_handler *find_handler(struct cmd_handler handlers[], int l, char *lin
int handle_command(struct sway_config *config, char *exec) { int handle_command(struct sway_config *config, char *exec) {
sway_log(L_INFO, "Handling command '%s'", exec); sway_log(L_INFO, "Handling command '%s'", exec);
char *ptr, *cmd; char *ptr, *cmd;
int ret;
if ((ptr = strchr(exec, ' ')) == NULL) { if ((ptr = strchr(exec, ' ')) == NULL) {
cmd = malloc(strlen(exec) + 1); cmd = exec;
strcpy(cmd, exec);
} else { } else {
int index = ptr - exec; int index = ptr - exec;
cmd = malloc(index + 1); cmd = malloc(index + 1);
@ -358,12 +359,12 @@ int handle_command(struct sway_config *config, char *exec) {
struct cmd_handler *handler = find_handler(handlers, sizeof(handlers) / sizeof(struct cmd_handler), cmd); struct cmd_handler *handler = find_handler(handlers, sizeof(handlers) / sizeof(struct cmd_handler), cmd);
if (handler == NULL) { if (handler == NULL) {
sway_log(L_ERROR, "Unknown command '%s'", cmd); sway_log(L_ERROR, "Unknown command '%s'", cmd);
return 0; // TODO: return error, probably ret = 0; // TODO: return error, probably
} } else {
int argc; int argc;
char **argv = split_directive(exec + strlen(handler->command), &argc); char **argv = split_directive(exec + strlen(handler->command), &argc);
int ret = handler->handle(config, argc, argv);
int i; int i;
ret = handler->handle(config, argc, argv);
for (i = 0; i < argc; ++i) { for (i = 0; i < argc; ++i) {
free(argv[i]); free(argv[i]);
} }
@ -371,5 +372,9 @@ int handle_command(struct sway_config *config, char *exec) {
if (ret != 0) { if (ret != 0) {
sway_log(L_ERROR, "Command failed: %s", cmd); sway_log(L_ERROR, "Command failed: %s", cmd);
} }
}
if(ptr) {
free(cmd);
}
return ret; return ret;
} }