Merge pull request #2433 from RyanDwyer/fix-sticky-infinite-loop

Fix infinite loop when focusing sticky containers via workspace command
This commit is contained in:
Drew DeVault 2018-08-07 10:27:25 -04:00 committed by GitHub
commit 84845adb8e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 10 deletions

View File

@ -411,17 +411,20 @@ bool workspace_switch(struct sway_container *workspace,
struct sway_container *floating =
next_output_prev_ws->sway_workspace->floating;
bool has_sticky = false;
for (int i = 0; i < floating->children->length; ++i) {
struct sway_container *floater = floating->children->items[i];
if (floater->is_sticky) {
has_sticky = true;
container_remove_child(floater);
container_add_child(workspace->sway_workspace->floating, floater);
if (floater == focus) {
seat_set_focus(seat, NULL);
seat_set_focus(seat, floater);
if (workspace != next_output_prev_ws) {
for (int i = 0; i < floating->children->length; ++i) {
struct sway_container *floater = floating->children->items[i];
if (floater->is_sticky) {
has_sticky = true;
container_remove_child(floater);
container_add_child(workspace->sway_workspace->floating,
floater);
if (floater == focus) {
seat_set_focus(seat, NULL);
seat_set_focus(seat, floater);
}
--i;
}
--i;
}
}