Fix crash when view maps while locked

When locked, there is no active workspace so it must find the
focus_inactive workspace instead.

Additionally, this adds a check for if a view maps while there are no
outputs connected and handles it gracefully.
This commit is contained in:
Ryan Dwyer 2018-10-13 19:15:04 +10:00
parent b80cf982ae
commit 9190735947
2 changed files with 14 additions and 1 deletions

View file

@ -180,6 +180,10 @@ void arrange_workspace(struct sway_workspace *workspace) {
if (config->reloading) { if (config->reloading) {
return; return;
} }
if (!workspace->output) {
// Happens when there are no outputs connected
return;
}
struct sway_output *output = workspace->output; struct sway_output *output = workspace->output;
struct wlr_box *area = &output->usable_area; struct wlr_box *area = &output->usable_area;
wlr_log(WLR_DEBUG, "Usable area for ws: %dx%d@%d,%d", wlr_log(WLR_DEBUG, "Usable area for ws: %dx%d@%d,%d",

View file

@ -504,7 +504,16 @@ static struct sway_workspace *select_workspace(struct sway_view *view) {
} }
// Use the focused workspace // Use the focused workspace
return seat_get_focused_workspace(seat); struct sway_node *node = seat_get_focus_inactive(seat, &root->node);
if (node && node->type == N_WORKSPACE) {
return node->sway_workspace;
} else if (node && node->type == N_CONTAINER) {
return node->sway_container->workspace;
}
// If there's no focus_inactive workspace then we must be running without
// any outputs connected
return root->saved_workspaces->items[0];
} }
static bool should_focus(struct sway_view *view) { static bool should_focus(struct sway_view *view) {