Fix bug with previous commit

This commit is contained in:
Drew DeVault 2018-03-31 10:47:04 -04:00
parent 8aa195e311
commit ccdcaa478f

View file

@ -175,11 +175,26 @@ static void handle_cursor_button(struct wl_listener *listener, void *data) {
double sx, sy; double sx, sy;
struct sway_container *cont = struct sway_container *cont =
container_at_cursor(cursor, &surface, &sx, &sy); container_at_cursor(cursor, &surface, &sx, &sy);
// TODO: Actually test if the surface accepts keyboard input, rather // Avoid moving keyboard focus from a surface that accepts it to one
// than assuming it does not // that does not unless the change would move us to a new workspace.
// Layer surfaces with keyboard_interactive=true will change how this //
// works, for example. // This prevents, for example, losing focus when clicking on swaybar.
if (!surface || cont->type == C_VIEW) { //
// TODO: Replace this condition with something like
// !surface_accepts_keyboard_input
if (surface && cont->type != C_VIEW) {
struct sway_container *new_ws = cont;
if (new_ws && new_ws->type != C_WORKSPACE) {
new_ws = container_parent(new_ws, C_WORKSPACE);
}
struct sway_container *old_ws = sway_seat_get_focus(cursor->seat);
if (old_ws && old_ws->type != C_WORKSPACE) {
old_ws = container_parent(old_ws, C_WORKSPACE);
}
if (new_ws != old_ws) {
sway_seat_set_focus(cursor->seat, cont);
}
} else {
sway_seat_set_focus(cursor->seat, cont); sway_seat_set_focus(cursor->seat, cont);
} }
} }