Make xwayland scale factor configurable via xwayland scale command.

This commit is contained in:
Dario Nieuwenhuis 2020-02-10 02:26:09 +01:00
parent 5e5e5f2ee5
commit cd9d1038a8
11 changed files with 120 additions and 18 deletions

View file

@ -291,6 +291,11 @@ sway_cmd seat_cmd_pointer_constraint;
sway_cmd seat_cmd_shortcuts_inhibitor; sway_cmd seat_cmd_shortcuts_inhibitor;
sway_cmd seat_cmd_xcursor_theme; sway_cmd seat_cmd_xcursor_theme;
sway_cmd xwayland_cmd_enable;
sway_cmd xwayland_cmd_disable;
sway_cmd xwayland_cmd_force;
sway_cmd xwayland_cmd_scale;
sway_cmd cmd_ipc_cmd; sway_cmd cmd_ipc_cmd;
sway_cmd cmd_ipc_events; sway_cmd cmd_ipc_events;
sway_cmd cmd_ipc_event_cmd; sway_cmd cmd_ipc_event_cmd;

View file

@ -528,6 +528,7 @@ struct sway_config {
enum sway_fowa focus_on_window_activation; enum sway_fowa focus_on_window_activation;
enum sway_popup_during_fullscreen popup_during_fullscreen; enum sway_popup_during_fullscreen popup_during_fullscreen;
enum xwayland_mode xwayland; enum xwayland_mode xwayland;
int32_t xwayland_scale;
// swaybg // swaybg
char *swaybg_command; char *swaybg_command;

View file

@ -97,6 +97,7 @@ static struct cmd_handler handlers[] = {
{ "unbindsym", cmd_unbindsym }, { "unbindsym", cmd_unbindsym },
{ "workspace", cmd_workspace }, { "workspace", cmd_workspace },
{ "workspace_auto_back_and_forth", cmd_ws_auto_back_and_forth }, { "workspace_auto_back_and_forth", cmd_ws_auto_back_and_forth },
{ "xwayland", cmd_xwayland },
}; };
/* Config-time only commands. Keep alphabetized */ /* Config-time only commands. Keep alphabetized */
@ -105,7 +106,6 @@ static struct cmd_handler config_handlers[] = {
{ "swaybg_command", cmd_swaybg_command }, { "swaybg_command", cmd_swaybg_command },
{ "swaynag_command", cmd_swaynag_command }, { "swaynag_command", cmd_swaynag_command },
{ "workspace_layout", cmd_workspace_layout }, { "workspace_layout", cmd_workspace_layout },
{ "xwayland", cmd_xwayland },
}; };
/* Runtime-only commands. Keep alphabetized */ /* Runtime-only commands. Keep alphabetized */

View file

@ -4,27 +4,39 @@
#include "sway/server.h" #include "sway/server.h"
#include "util.h" #include "util.h"
// must be in order for the bsearch
static struct cmd_handler xwayland_handlers[] = {
{ "enable", xwayland_cmd_enable },
{ "disable", xwayland_cmd_disable },
{ "force", xwayland_cmd_force },
{ "scale", xwayland_cmd_scale },
};
struct cmd_results *cmd_xwayland(int argc, char **argv) { struct cmd_results *cmd_xwayland(int argc, char **argv) {
struct cmd_results *error = NULL; #ifdef HAVE_XWAYLAND
if ((error = checkarg(argc, "xwayland", EXPECTED_EQUAL_TO, 1))) { struct cmd_results *error;
while (argc > 0) {
config->handler_context.leftovers.argc = 0;
config->handler_context.leftovers.argv = NULL;
if (find_handler(*argv, xwayland_handlers, sizeof(xwayland_handlers))) {
error = config_subcommand(argv, argc, xwayland_handlers,
sizeof(xwayland_handlers));
} else {
error = cmd_results_new(CMD_INVALID,
"Invalid output subcommand: %s.", *argv);
}
if (error != NULL) {
return error; return error;
} }
#ifdef HAVE_XWAYLAND argc = config->handler_context.leftovers.argc;
enum xwayland_mode xwayland; argv = config->handler_context.leftovers.argv;
if (strcmp(argv[0], "force") == 0) {
xwayland = XWAYLAND_MODE_IMMEDIATE;
} else if (parse_boolean(argv[0], true)) {
xwayland = XWAYLAND_MODE_LAZY;
} else {
xwayland = XWAYLAND_MODE_DISABLED;
} }
if (config->reloading && config->xwayland != xwayland) { config->handler_context.leftovers.argc = 0;
return cmd_results_new(CMD_FAILURE, config->handler_context.leftovers.argv = NULL;
"xwayland can only be enabled/disabled at launch");
}
config->xwayland = xwayland;
#else #else
sway_log(SWAY_INFO, "Ignoring `xwayland` command, " sway_log(SWAY_INFO, "Ignoring `xwayland` command, "
"sway hasn't been built with Xwayland support"); "sway hasn't been built with Xwayland support");

View file

@ -0,0 +1,15 @@
#include "sway/commands.h"
#include "sway/config.h"
struct cmd_results *xwayland_cmd_disable(int argc, char **argv) {
if (config->reloading && config->xwayland != XWAYLAND_MODE_DISABLED) {
return cmd_results_new(CMD_FAILURE,
"xwayland can only be enabled/disabled at launch");
}
config->xwayland = XWAYLAND_MODE_DISABLED;
config->handler_context.leftovers.argc = argc;
config->handler_context.leftovers.argv = argv;
return NULL;
}

View file

@ -0,0 +1,15 @@
#include "sway/commands.h"
#include "sway/config.h"
struct cmd_results *xwayland_cmd_enable(int argc, char **argv) {
if (config->reloading && config->xwayland != XWAYLAND_MODE_LAZY) {
return cmd_results_new(CMD_FAILURE,
"xwayland can only be enabled/disabled at launch");
}
config->xwayland = XWAYLAND_MODE_LAZY;
config->handler_context.leftovers.argc = argc;
config->handler_context.leftovers.argv = argv;
return NULL;
}

View file

@ -0,0 +1,15 @@
#include "sway/commands.h"
#include "sway/config.h"
struct cmd_results *xwayland_cmd_force(int argc, char **argv) {
if (config->reloading && config->xwayland != XWAYLAND_MODE_IMMEDIATE) {
return cmd_results_new(CMD_FAILURE,
"xwayland can only be enabled/disabled at launch");
}
config->xwayland = XWAYLAND_MODE_IMMEDIATE;
config->handler_context.leftovers.argc = argc;
config->handler_context.leftovers.argv = argv;
return NULL;
}

View file

@ -0,0 +1,31 @@
#include <strings.h>
#include "sway/commands.h"
#include "sway/config.h"
#include "sway/server.h"
#include "log.h"
struct cmd_results *xwayland_cmd_scale(int argc, char **argv) {
if (!argc) {
return cmd_results_new(CMD_INVALID, "Missing scale argument.");
}
char *end;
int32_t scale = strtol(*argv, &end, 10);
if (*end) {
return cmd_results_new(CMD_INVALID, "Invalid scale.");
}
if(scale < 1) {
return cmd_results_new(CMD_INVALID, "Invalid scale: must be 1 or higher");
}
config->xwayland_scale = scale;
if(server.xwayland.wlr_xwayland != NULL) {
wlr_xwayland_set_scale(server.xwayland.wlr_xwayland, scale);
}
config->handler_context.leftovers.argc = argc - 1;
config->handler_context.leftovers.argv = argv + 1;
return NULL;
}

View file

@ -244,6 +244,7 @@ static void config_defaults(struct sway_config *config) {
config->focus_on_window_activation = FOWA_URGENT; config->focus_on_window_activation = FOWA_URGENT;
config->popup_during_fullscreen = POPUP_SMART; config->popup_during_fullscreen = POPUP_SMART;
config->xwayland = XWAYLAND_MODE_LAZY; config->xwayland = XWAYLAND_MODE_LAZY;
config->xwayland_scale = 1;
config->titlebar_border_thickness = 1; config->titlebar_border_thickness = 1;
config->titlebar_h_padding = 5; config->titlebar_h_padding = 5;

View file

@ -680,6 +680,8 @@ void handle_xwayland_ready(struct wl_listener *listener, void *data) {
wl_container_of(listener, server, xwayland_ready); wl_container_of(listener, server, xwayland_ready);
struct sway_xwayland *xwayland = &server->xwayland; struct sway_xwayland *xwayland = &server->xwayland;
wlr_xwayland_set_scale(xwayland->wlr_xwayland, config->xwayland_scale);
xcb_connection_t *xcb_conn = xcb_connect(NULL, NULL); xcb_connection_t *xcb_conn = xcb_connect(NULL, NULL);
int err = xcb_connection_has_error(xcb_conn); int err = xcb_connection_has_error(xcb_conn);
if (err) { if (err) {

View file

@ -191,6 +191,11 @@ sway_sources = files(
'commands/output/toggle.c', 'commands/output/toggle.c',
'commands/output/transform.c', 'commands/output/transform.c',
'commands/xwayland/enable.c',
'commands/xwayland/disable.c',
'commands/xwayland/force.c',
'commands/xwayland/scale.c',
'tree/arrange.c', 'tree/arrange.c',
'tree/container.c', 'tree/container.c',
'tree/node.c', 'tree/node.c',