launcher: make launcher context seat aware

This commit is contained in:
Ronan Pigott 2022-11-30 11:54:15 -07:00
parent 842609da64
commit dbc1eec850
3 changed files with 68 additions and 21 deletions

View file

@ -6,7 +6,7 @@
struct launcher_ctx { struct launcher_ctx {
pid_t pid; pid_t pid;
char *name; char *fallback_name;
struct wlr_xdg_activation_token_v1 *token; struct wlr_xdg_activation_token_v1 *token;
struct wl_listener token_destroy; struct wl_listener token_destroy;
@ -26,7 +26,10 @@ void launcher_ctx_consume(struct launcher_ctx *ctx);
void launcher_ctx_destroy(struct launcher_ctx *ctx); void launcher_ctx_destroy(struct launcher_ctx *ctx);
struct launcher_ctx *launcher_ctx_create(void); struct launcher_ctx *launcher_ctx_create_internal(void);
struct launcher_ctx *launcher_ctx_create(
struct wlr_xdg_activation_token_v1 *token, struct sway_node *node);
const char *launcher_ctx_get_token_name(struct launcher_ctx *ctx); const char *launcher_ctx_get_token_name(struct launcher_ctx *ctx);

View file

@ -63,7 +63,7 @@ struct cmd_results *cmd_exec_process(int argc, char **argv) {
} }
pid_t pid, child; pid_t pid, child;
struct launcher_ctx *ctx = launcher_ctx_create(); struct launcher_ctx *ctx = launcher_ctx_create_internal();
// Fork process // Fork process
if ((pid = fork()) == 0) { if ((pid = fork()) == 0) {
// Fork child process again // Fork child process again

View file

@ -69,7 +69,7 @@ void launcher_ctx_destroy(struct launcher_ctx *ctx) {
wl_list_remove(&ctx->token_destroy.link); wl_list_remove(&ctx->token_destroy.link);
wl_list_remove(&ctx->link); wl_list_remove(&ctx->link);
wlr_xdg_activation_token_v1_destroy(ctx->token); wlr_xdg_activation_token_v1_destroy(ctx->token);
free(ctx->name); free(ctx->fallback_name);
free(ctx); free(ctx);
} }
@ -114,22 +114,22 @@ struct sway_workspace *launcher_ctx_get_workspace(
break; break;
case N_OUTPUT: case N_OUTPUT:
output = ctx->node->sway_output; output = ctx->node->sway_output;
ws = workspace_by_name(ctx->name); ws = workspace_by_name(ctx->fallback_name);
if (!ws) { if (!ws) {
sway_log(SWAY_DEBUG, sway_log(SWAY_DEBUG,
"Creating workspace %s for pid %d because it disappeared", "Creating workspace %s for pid %d because it disappeared",
ctx->name, ctx->pid); ctx->fallback_name, ctx->pid);
if (!output->enabled) { if (!output->enabled) {
sway_log(SWAY_DEBUG, sway_log(SWAY_DEBUG,
"Workspace output %s is disabled, trying another one", "Workspace output %s is disabled, trying another one",
output->wlr_output->name); output->wlr_output->name);
output = NULL; output = NULL;
} }
ws = workspace_create(output, ctx->name); ws = workspace_create(output, ctx->fallback_name);
} }
break; break;
case N_ROOT: case N_ROOT:
ws = workspace_create(NULL, ctx->name); ws = workspace_create(NULL, ctx->fallback_name);
break; break;
} }
@ -148,8 +148,8 @@ static void ctx_handle_node_destroy(struct wl_listener *listener, void *data) {
wl_list_init(&ctx->node_destroy.link); wl_list_init(&ctx->node_destroy.link);
// We want to save this ws name to recreate later, hopefully on the // We want to save this ws name to recreate later, hopefully on the
// same output // same output
free(ctx->name); free(ctx->fallback_name);
ctx->name = strdup(ws->name); ctx->fallback_name = strdup(ws->name);
if (!ws->output || ws->output->node.destroying) { if (!ws->output || ws->output->node.destroying) {
// If the output is being destroyed it would be pointless to track // If the output is being destroyed it would be pointless to track
// If the output is being disabled, we'll find out if it's still // If the output is being disabled, we'll find out if it's still
@ -178,21 +178,41 @@ static void token_handle_destroy(struct wl_listener *listener, void *data) {
launcher_ctx_destroy(ctx); launcher_ctx_destroy(ctx);
} }
struct launcher_ctx *launcher_ctx_create() { struct launcher_ctx *launcher_ctx_create(struct wlr_xdg_activation_token_v1 *token,
struct sway_seat *seat = input_manager_current_seat(); struct sway_node *node) {
struct sway_workspace *ws = seat_get_focused_workspace(seat); struct launcher_ctx *ctx = calloc(1, sizeof(struct launcher_ctx));
if (!ws) {
sway_log(SWAY_DEBUG, "Failed to create launch context. No workspace."); const char *fallback_name = NULL;
struct sway_workspace *ws = NULL;
switch (node->type) {
case N_CONTAINER:
// Unimplemented
free(ctx);
return NULL;
case N_WORKSPACE:
ws = node->sway_workspace;
fallback_name = ws->name;
break;
case N_OUTPUT:;
struct sway_output *output = node->sway_output;
ws = output_get_active_workspace(output);
fallback_name = ws ? ws->name : NULL;
break;
case N_ROOT:
// Unimplemented
free(ctx);
return NULL; return NULL;
} }
struct launcher_ctx *ctx = calloc(1, sizeof(struct launcher_ctx)); if (!fallback_name) {
struct wlr_xdg_activation_token_v1 *token = // TODO: implement a better fallback.
wlr_xdg_activation_token_v1_create(server.xdg_activation_v1); free(ctx);
token->data = ctx; return NULL;
ctx->name = strdup(ws->name); }
ctx->fallback_name = strdup(fallback_name);
ctx->token = token; ctx->token = token;
ctx->node = &ws->node; ctx->node = node;
ctx->node_destroy.notify = ctx_handle_node_destroy; ctx->node_destroy.notify = ctx_handle_node_destroy;
wl_signal_add(&ctx->node->events.destroy, &ctx->node_destroy); wl_signal_add(&ctx->node->events.destroy, &ctx->node_destroy);
@ -202,6 +222,30 @@ struct launcher_ctx *launcher_ctx_create() {
wl_list_init(&ctx->link); wl_list_init(&ctx->link);
wl_list_insert(&server.pending_launcher_ctxs, &ctx->link); wl_list_insert(&server.pending_launcher_ctxs, &ctx->link);
token->data = ctx;
return ctx;
}
// Creates a context with a new token for the internal launcher
struct launcher_ctx *launcher_ctx_create_internal() {
struct sway_seat *seat = input_manager_current_seat();
struct sway_workspace *ws = seat_get_focused_workspace(seat);
if (!ws) {
sway_log(SWAY_DEBUG, "Failed to create launch context. No workspace.");
return NULL;
}
struct wlr_xdg_activation_token_v1 *token =
wlr_xdg_activation_token_v1_create(server.xdg_activation_v1);
token->seat = seat->wlr_seat;
struct launcher_ctx *ctx = launcher_ctx_create(token, &ws->node);
if (!ctx) {
wlr_xdg_activation_token_v1_destroy(token);
return NULL;
}
return ctx; return ctx;
} }