mirror of
https://github.com/swaywm/sway.git
synced 2024-11-19 14:39:15 +00:00
f627cd77d6
Make the status command a process group leader and change the kill(2)
calls to target the new process group. Signals sent by swaybar will then
be received by both the status command and its children, if any. While
here, check the result of fork(2).
Without this, children spawned by the status command may not receive the
signals sent by swaybar. As a result, these children may be orphaned on
reload.
The issue could be shown by setting the bar to
bar {
status_command i3status | tee /tmp/i3status.out
}
which would leave orphaned processes for each reload of sway
$ ps o pid,ppid,cmd | grep i3status | grep -v grep
43633 43624 sh -c i3status | tee /tmp/i3status.out
43634 43633 i3status
43635 43633 tee /tmp/i3status.out
$ swaymsg reload
$ ps o pid,ppid,cmd | grep i3status | grep -v grep
43634 1 i3status
43635 1 tee /tmp/i3status.out
43801 43788 sh -c i3status | tee /tmp/i3status.out
43802 43801 i3status
43803 43801 tee /tmp/i3status.out
This fixes #5584.
|
||
|---|---|---|
| .. | ||
| tray | ||
| bar.c | ||
| config.c | ||
| i3bar.c | ||
| input.c | ||
| ipc.c | ||
| main.c | ||
| meson.build | ||
| render.c | ||
| status_line.c | ||
| swaybar-protocol.7.scd | ||