Riteo
9db000a9af
Check also if there are json subtitles
2024-08-14 02:55:29 +02:00
Riteo
62e274f515
Move regular subtitles options to their loop
2024-08-14 02:10:14 +02:00
Riteo
e202aae5d6
Remove redundant copy_unknown
2024-08-14 02:03:09 +02:00
Riteo
3b8050da5b
Merge remote-tracking branch 'origin/master' into json-subtitles
2024-08-14 02:02:56 +02:00
Riteo
38a9f70044
Use a map for JSON sub handling instead of two lists
2024-08-14 01:16:15 +02:00
Riteo
550b3a046a
Use the -copy_unknown flag in the stream copy otions
...
Also split the yield expression as the comment above was a bit
misleading (it was only related to the `-dn` flag).
2024-08-13 22:30:08 +02:00
bashonly
6aaf96a3d6
[cleanup] Misc ( #10075 )
...
Closes #10303
Authored by: bashonly, seproDev, jucor, c-basalt
Co-authored-by: sepro <4618135+seproDev@users.noreply.github.com>
Co-authored-by: Julien Cornebise <julien@cornebise.com>
Co-authored-by: c-basalt <117849907+c-basalt@users.noreply.github.com>
2024-07-01 22:51:27 +00:00
Riteo
ba3a7232f0
[pp/FFmpegEmbedSubtitle] Embed JSON subtitles as Matroska attachments
...
Since we can't embed them as regular subtitles (due to them not having
any consistent structure), we embed them as file attachments, if
exporting as Matroska.
This allows us to have single-file downloads with everything embedded
for e.g. archival purposes.
2024-06-14 16:56:54 +02:00
Riteo
339828d777
[pp/FFmpegMetadata] Use metadata stream specifier for info.json
...
The old stream index specifiers would indiscriminately select any JSON
attachment, which made stuff like embedding live chat json data risky if
not impossible.
Also adds `-copy_unknown` as JSON data is "unknown" according to FFmpeg
(since it has no codec id) and thus would otherwise be rejected by
default.
2024-06-14 16:56:52 +02:00
sepro
add96eb9f8
[cleanup] Add more ruff rules ( #10149 )
...
Authored by: seproDev
Reviewed-by: bashonly <88596187+bashonly@users.noreply.github.com>
Reviewed-by: Simon Sawicki <contact@grub4k.xyz>
2024-06-12 01:09:58 +02:00
Lev
104a7b5a46
[ie] Migrate commonly plural fields to lists ( #8917 )
...
Authored by: llistochek, pukkandan
Related: #3944
2024-02-20 12:49:24 +05:30
bashonly
deeb13eae8
[pp/FFmpegMetadata] Embed stream metadata in single format downloads ( #8647 )
...
Closes #8568
Authored by: bashonly
2023-11-26 02:40:09 +00:00
bashonly
3f7e2bd80e
[FFmpegFixupM3u8PP] Check audio codec before fixup ( #6778 )
...
Closes #6673
Authored by: bashonly
2023-04-13 19:21:09 +00:00
Lesmiscore
0f0875ed55
[postprocessor/EmbedThumbnail,postprocessor/FFmpegMetadata] Fix error on attaching thumbnails and info json for mkv/mka ( #6647 )
...
Authored by: Lesmiscore
Current yt-dlp code never hit this bug, but would hit once filename sanitization gets better
2023-03-28 01:17:42 +09:00
bashonly
01ddec7e66
[postprocessor] Fix chapters if duration is not extracted ( #6037 )
...
Authored by: bashonly
2023-03-08 13:10:19 +00:00
Chris Caruso
f737fb16d8
[ExtractAudio] Handle outtmpl without ext ( #6005 )
...
Authored by: carusocr
Closes #5968
2023-02-17 13:36:15 +05:30
pukkandan
d80ca5deaa
[utils] mimetype2ext
: weba is not standard
...
Fix bug in fbb7383306
, 2647c933b8
Closes #5935
2023-01-03 11:25:01 +05:30
pukkandan
08e29b9f1f
[cleanup] Misc
...
Closes #5576 , closes #5887
2023-01-02 19:40:15 +05:30
pukkandan
69f5fe45b9
[FFmpegVideoConvertor] Add gif
to --recode-video
2022-12-23 01:44:20 +05:30
Robert Geislinger
7aaf4cd2a8
[cleanup] Misc
...
Closes #5471 , Closes #5312
Authored by: pukkandan, Alienmaster
2022-11-11 15:48:29 +05:30
pukkandan
8522226d2f
[ThumbnailsConvertor] Fix filename escaping
...
Closes #4604
Authored by: pukkandan, dirkf
2022-11-11 15:28:19 +05:30
pukkandan
da4db748fa
[utils] Add deprecation_warning
...
See https://github.com/yt-dlp/yt-dlp/pull/2173#issuecomment-1097021515
2022-08-30 21:03:07 +05:30
pukkandan
0e0ce898f6
[ThumbnailsConvertor] Fix conversion after fixup_webp
...
Closes #4565
2022-08-14 20:34:55 +05:30
pukkandan
8420a4d063
[ffmpeg] Smarter detection of ffprobe filename
2022-08-11 07:23:45 +05:30
pukkandan
c220d9efc8
[ffmpeg] Disable avconv unless --prefer-avconv
2022-08-09 05:15:38 +05:30
pukkandan
5f2a7f7c4a
[FFmpegThumbnailsConvertor] Fix conversion from GIF
...
Closes #2988
2022-08-01 07:36:08 +05:30
pukkandan
4f04be6add
Validate --merge-output-format
...
Closes #4489
2022-07-31 02:20:14 +05:30
pukkandan
8dc5930511
[utils, cleanup] Consolidate known media extensions
2022-07-31 02:20:13 +05:30
pukkandan
6a7d3a0a09
[ffmpeg] Set ffmpeg_location
in a contextvar
...
Fixes #2191 for the CLI, but not when used through the API
2022-07-31 02:20:12 +05:30
pukkandan
3bec830a59
Reject entire playlists faster with --match-filter
...
Rejected based on `playlist_id` etc can be checked before any entries are extracted
Related: #4383
2022-07-26 09:33:12 +05:30
pukkandan
f2df407165
[cleanup] Misc cleanup
2022-07-09 09:07:10 +05:30
crazymoose77756
962ffcf89c
[cleanup] Fix some typos ( #4194 )
...
Authored by: crazymoose77756
2022-06-26 17:50:06 -07:00
pukkandan
f67baae17e
[ffmpeg] Write full output to debug on error
...
Bug in f0c9fb9682
2022-06-23 09:17:34 +05:30
christoph-heinrich
e121e3cee7
[cleanup] Minor fixes ( #4096 )
...
Authored by: christoph-heinrich
2022-06-17 18:57:22 -07:00
pukkandan
f0c9fb9682
[utils] Popen
: Refactor to use contextmanager
...
Fixes https://github.com/yt-dlp/yt-dlp/issues/3531#issuecomment-1156223597
2022-06-16 06:23:50 +05:30
pukkandan
e0ab98541c
[ExtractAudio] Allow conditional conversion
...
Closes #1715
2022-06-06 21:51:28 +05:30
pukkandan
35faefee5d
[ExtractAudio, cleanup] Refactor
2022-06-06 21:49:57 +05:30
pukkandan
00bbc5f177
[ThumbnailsConvertor] Allow conditional conversion
...
Closes #3970
2022-06-05 20:51:19 +05:30
pukkandan
1890fc6389
[cleanup] Misc fixes
...
Cherry-picks from: #3498 , #3947
Related: #3949 , https://github.com/yt-dlp/yt-dlp/issues/1839#issuecomment-1140313836
Authored by: pukkandan, flashdagger, gamer191
2022-06-03 21:45:35 +05:30
pukkandan
8a82af3511
[cleanup] Misc fixes and cleanup
...
Closes #3780 , Closes #3853 , Closes #3850
2022-05-27 04:43:43 +05:30
pukkandan
d9473db78a
[ModifyChapters] Fix repeated removal of small segments
...
Closes #3846
2022-05-23 16:12:33 +05:30
pukkandan
3a85e9cee9
[ffmpeg] Check version lazily
...
Closes #3830
2022-05-22 19:56:22 +05:30
pukkandan
5792c950bf
[compat] Implement compat.imghdr
...
Python 3.11 deprecates `imghdr` module
2022-05-17 19:46:01 +05:30
pukkandan
43d7f5a5d0
[EmbedThumbnail] Do not obey -k
2022-05-01 04:58:26 +05:30
pukkandan
e13945a2fe
[ffmpeg] Fix features detection
2022-04-27 05:36:06 +05:30
pukkandan
ca04e1bf49
[Metadata] Remove filename from attached info-json
2022-04-27 01:19:06 +05:30
pukkandan
1e9969f4f5
bugfix for a44ca5a470
, 19a0394044
, 77f9033095
...
Closes #3472
2022-04-19 02:59:20 +05:30
pukkandan
743f39750c
Fix bug in 66cf3e1001
2022-04-12 19:57:08 +05:30
pukkandan
66cf3e1001
[EmbedSubtitle] Enable for more video extensions
...
Closes #3382
2022-04-12 05:32:53 +05:30
pukkandan
f82711587c
[cleanup] Sort imports
...
Using https://github.com/PyCQA/isort
isort -m VERTICAL_HANGING_INDENT --py 36 -l 80 --rr -n --tc .
2022-04-12 05:32:52 +05:30