Yen Chi Hsuan
23495d6a39
Revert "[ffmpeg] Fix embedding subtitles ( #9063 )"
...
This reverts commit ccff2c404dFixes #10081 .
The new approach breaks embedding subtitles into video-only or
audio-only files. FFMpeg provides a trick: add '?' after the argument of
'-map' so that a missing stream is ignored. For example:
opts = [
'-map', '0:v?',
'-c:v', 'copy',
'-map', '0:a?',
'-c:a', 'copy',
# other options...
]
Unfortunately, such a format is not implemented in avconv, either.
I guess adding '-ignore_unknown' if self.basename == 'ffmpeg' is the
best solution. However, the example mentioned in #9063 no longer serves
problematic files, so I can't test it. I'll reopen #9063 and wait for
another example so that I can test '-ignore_unknown'.
2016-07-15 20:02:36 +08:00
Yen Chi Hsuan
5b6a74856b
Merge pull request #9288 from reyyed/issue#9063fix
...
[ffmpeg] Fix embedding subtitles (#9063 )
2016-07-09 14:29:53 +08:00
Yen Chi Hsuan
702ccf2dc0
[compat] Rename shlex_quote and remove unused subprocess_check_output
2016-05-10 16:00:21 +08:00
Sergey M․
4bd143a3a0
[postprocessor/ffmpeg] Simplify metadata preparation and add track related metafields ( Closes #9357 )
2016-05-01 10:56:54 +06:00
Wang Jun Tham
ccff2c404d
[ffmpeg] Fix embedding subtitles ( #9063 )
...
Changed command line parameters for ffmpeg when embedding subtitles.
Changed to ‘-map 0:v -c:v copy -map 0:a -c:a copy’
2016-04-24 00:08:02 +08:00
remitamine
b9f2fdd37f
[ffmpeg] Clarify rationale for pipe(-) exclusion in _ffmpeg_filename_argument
2016-04-16 21:50:13 +01:00
remitamine
d868f43c58
[ffmpeg] check for - file name in _ffmpeg_filename_argument
2016-04-16 19:45:56 +01:00
remitamine
0750b2491f
[ffmpeg] try to convert tt subtitles usng dfxp2srt
2016-04-01 19:47:49 +01:00
Sergey M․
40025ee2a3
[postprocessort/ffmpeg] Allow embedding webvtt into webm ( Closes #8874 )
2016-03-20 04:12:34 +06:00
remitamine
2e7e561c1d
Merge pull request #8611 from remitamine/ffmpegfd
...
[downloader/external] Add FFmpegFD
2016-03-13 21:30:27 +01:00
remitamine
a755f82549
[ffmpeg] convert format ext to ffmpeg output formats codes
2016-03-13 12:15:29 +01:00
remitamine
090eb8e25f
Merge pull request #8718 from remitamine/m3u8-fixup
...
Add fixup for media files produced by HlsNative downloader(fixes #4776 )
2016-03-05 18:37:28 +01:00
Yen Chi Hsuan
e9c0cdd389
[jython] Introduce compat_os_name
...
os.name is always 'java' on Jython
2016-03-03 19:24:24 +08:00
remitamine
f17f86513e
Add fixup for media files produced by HlsNative downloader( fixes #4776 )
2016-03-01 21:10:41 +01:00
Yen Chi Hsuan
7360db05b4
[postprocessor/embedthumbnail] Allow mkv to embed thumbnails
...
Fixes #6046
2016-02-21 03:32:03 +08:00
Sergey M․
611c1dd96e
[refactor] Single quotes consistency
2016-02-14 15:37:17 +06:00
Jaime Marquínez Ferrándiz
d4f8e83404
[FFmpegSubtitlesConvertorPP] remove unused variable
2016-02-06 19:04:53 +01:00
Jaime Marquínez Ferrándiz
7b8b007cd9
[FFmpegSubtitlesConvertorPP] remove intermediate srt files
2016-02-06 19:04:18 +01:00
Jaime Marquínez Ferrándiz
3547d26587
[FFmpegSubtitlesConvertorPP] correctly update the extension ( fixes #8444 )
2016-02-06 18:58:18 +01:00
Jaime Marquínez Ferrándiz
7e62c2eb6d
[FFmpegSubtitlesConvertorPP] fix not working when srt is used as the intermediate format between ttml/dfxp and other format
...
It was trying to use the ttml/dfxp file with ffmpeg, which doesn't have support for them.
I broke it in e04398e397
2016-02-06 18:51:05 +01:00
remitamine
7d3a035ee0
[ffmpeg] check for m3u8 protocol in FFmpegMetadataPP
2016-02-05 17:12:49 +01:00
remitamine
593e0f43b4
[ffmpeg] fix condition( fixes #8440 )
2016-02-05 15:12:06 +01:00
remitamine
6fba62c87a
[ffmpeg] fix adding metadata when using --hls-prefer-native( #8350 )
2016-02-02 22:14:23 +01:00
remitamine
fae45ede08
Merge pull request #8354 from remitamine/m3u8_metadata
...
[ffmpeg] fix adding metadata when using m3u8_native(fixes #8350 )
2016-02-02 19:13:58 +01:00
Jaime Marquínez Ferrándiz
e04398e397
[FFmpegSubtitlesConvertorPP] delete old subtitle files ( fixes #8382 )
2016-01-31 14:22:36 +01:00
remitamine
cf57433bbd
[ffmpeg] fix adding metadata when using m3u8_native( fixes #8350 )
2016-01-28 18:57:32 +01:00
Juan M Martínez
374c761e77
[FFmpegPostProcessor] Default of prefer ffmpeg
...
When no `downloader` is passed to `FFmpegPostProcessor`
an exception was raised trying to get the prefer ffmpeg param.
AttributeError: 'NoneType' object has no attribute 'params'
This fixes and defaults to `False`.
2015-12-09 20:56:00 -03:00
Sergey M․
deb85c32bb
[postprocessor/ffmpeg] Use ffmpeg as prefix since it's used all over the places ( Closes #7371 )
2015-11-06 21:56:31 +06:00
Jaime Marquínez Ferrándiz
8a7bbd1606
[postprocessor/ffmpeg] Always use the 'file:' protocol for filenames ( fixes #6874 )
...
If the filename contains ':' it is interpreted as a protocol.
It also handles filenames starting with '-'.
2015-09-18 14:38:35 +02:00
Jaime Marquínez Ferrándiz
3026164b16
[postprocessor/common] Use 'self._downloader.params' instead of 'self.params'
...
'self.params' is not defined
2015-09-05 12:11:36 +02:00
Sergey M․
6270239a6d
[postprocessor/common] Use generalized cli option converters
2015-09-05 03:06:53 +06:00
Jaime Marquínez Ferrándiz
9750e7d70e
[postprocessor/ffmpeg] Don't use '[youtube] ...' in messages
...
Because it can be used for other extractors.
2015-07-14 12:56:32 +02:00
Sergey M․
15006fedb9
[postprocessor/ffmpeg] Spread postprocessor args usage on all ffmpeg extractors
2015-07-11 22:42:03 +06:00
Sergey M․
e35b23f54d
[postprocessor/common] Improve postprocessor args fetching and clarify doc
2015-07-11 22:41:33 +06:00
Sergey M․
f72b0a6032
Revert xvid to avi and make docs to be similar to existing external downloader option
2015-07-11 22:15:16 +06:00
Sergey M․
ac9ed061ec
Merge branch 'master' of https://github.com/aurium/youtube-dl into aurium-master
2015-07-11 21:58:12 +06:00
Aurélio A. Heckert
aa5d9a79d6
Simplify postprocessor_args transmission to PP base class
...
* Remove `extra_cmd_args` transmission from sub to super class.
* Simplify params transmission through `downloader.params`.
2015-07-01 20:12:26 -03:00
Aurélio A. Heckert
1866432db7
Rename --pp-params to --postprocessor-args and access value as super class attribute
2015-06-30 16:22:09 -03:00
Yen Chi Hsuan
396726244a
[utils/ffmpeg] Move ISO 639 related codes to utils
2015-06-21 18:53:17 +08:00
Yen Chi Hsuan
c33a8639a7
[postprocessor/embedthumbnail] Skipping if thumbnail file missing
...
Fixes #5996
2015-06-18 22:05:02 +08:00
Aurélio A. Heckert
14835de9fb
Use shlex.split for --pp-params and update related docs.
2015-06-16 18:10:31 -03:00
Aurélio A. Heckert
d84f1d14b5
Adds support for XviD output with extra parametrization
...
As the "LG Time Machine" (a (not so) smart TV) has a limitation for video dimensions (as for codecs), I take to implement an extra parameter `--pp-params` where we can send extra parameterization for the video converter (post-processor).
Example:
```
$ youtube-dl --recode-video=xvid --pp-params='-s 720x480' -c https://www.youtube.com/watch?v=BE7Qoe2ZiXE
```
That works fine on a 4yo LG Time Machine.
Closes #5733
2015-06-09 22:08:16 -03:00
pulpe
d6aa68ce75
[postprocessor/embedthumbnail] embed mp4 too ( fixes #5840 )
2015-05-29 12:47:20 +02:00
Sergey M․
98b8ec8616
Merge branch 'best-fallback-on-outdated-avconv' of https://github.com/dstftw/youtube-dl into dstftw-best-fallback-on-outdated-avconv
...
Conflicts:
youtube_dl/YoutubeDL.py
2015-05-14 15:18:58 +06:00
Yen Chi Hsuan
c827d4cfdb
[xattr] Enhanced error messages on Windows
2015-05-14 16:53:10 +08:00
Yen Chi Hsuan
fbff30d2db
[xattr] Catch 'Argument list too long'
2015-05-14 14:51:00 +08:00
Yen Chi Hsuan
86c7fdb17c
[xattr] Enhance error handling to catch ENOSPC
...
Fixes #5589
2015-05-14 14:28:41 +08:00
Yen Chi Hsuan
2cc6d13547
[postprocessor/embedthumbnail] Encode arguments in calling AtomicParsley
2015-05-14 04:41:30 +08:00
Yen Chi Hsuan
bb8ca1d112
[postprocessor/embedthumbnail] Use run_ffmpeg_multiple_files
2015-05-14 02:35:28 +08:00
Yen Chi Hsuan
8e59539752
[postprocessor/embedthumbnail] Use thumbnails downloaded by YoutubeDL
2015-05-14 02:32:00 +08:00
