Only free() after xstrdup()

2024-11-28 05:41:31 +00:00 · 2014-10-22 15:05:14 +01:00 · 2014-10-22 15:05:14 +01:00 · 35f3b250bb
parent 6d04c5329e
commit 35f3b250bb
1 changed files with 1 additions and 2 deletions
--- a/noice.c
+++ b/noice.c
@ -128,12 +128,11 @@ xdirname(const char *path)
 	 * original string if we lose track of it. */
 	tmp = xstrdup(path);
 	p = dirname(tmp);
-	free(tmp);
 	if (p == NULL)
 		printerr(1, "dirname");
-
 	/* Make sure this is a malloc(3)-ed string */
 	p = xstrdup(p);
+	free(tmp);
 	return p;
 }