mirrors
/
nnn
mirror of https://github.com/jarun/nnn.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix: properly update mode after xchmod 

xchmod now returns the new mode through a pointer, no need to assume all
executable bits were toggled.

Closes: https://github.com/jarun/nnn/issues/1657
This commit is contained in:
NRK 2023-05-26 19:27:07 +06:00
parent 4149a2619d
commit b2b830e69d
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/nnn.c
View File

@ -4604,12 +4604,12 @@ static bool show_stats(char *fpath)
return TRUE; return TRUE;
} }
static bool xchmod(const char *fpath, mode_t mode) static bool xchmod(const char *fpath, mode_t *mode)
{ {
/* (Un)set (S_IXUSR | S_IXGRP | S_IXOTH) */ /* (Un)set (S_IXUSR | S_IXGRP | S_IXOTH) */
(0100 & mode) ? (mode &= ~0111) : (mode |= 0111); (0100 & *mode) ? (*mode &= ~0111) : (*mode |= 0111);
return (chmod(fpath, mode) == 0); return (chmod(fpath, *mode) == 0);
} }
static size_t get_fs_info(const char *path, uchar_t type) static size_t get_fs_info(const char *path, uchar_t type)
@ -7381,13 +7381,13 @@ nochange:
if ((sel == SEL_STATS && !show_stats(newpath)) if ((sel == SEL_STATS && !show_stats(newpath))
|| (lstat(newpath, &sb) == -1) || (lstat(newpath, &sb) == -1)
|| (sel == SEL_CHMODX && !xchmod(newpath, sb.st_mode))) { || (sel == SEL_CHMODX && !xchmod(newpath, &sb.st_mode))) {
printwarn(&presel); printwarn(&presel);
goto nochange; goto nochange;
} }
if (sel == SEL_CHMODX) if (sel == SEL_CHMODX)
pdents[cur].mode ^= 0111; pdents[cur].mode = sb.st_mode;
} }
break; break;
case SEL_REDRAW: // fallthrough case SEL_REDRAW: // fallthrough