Commit graph

4209 commits

Author SHA1 Message Date
Luuk van Baal d3b5d0e49d
perf(preview-tui): replace env for loop with parameter expansion 2023-04-21 10:39:10 +02:00
musjj 432b0755d3 feat(preview-tui): handle quoting in start_preview more robustly
This commit makes the script more resistant to naughty filenames.
The script now depends on bash for the following features:
- Arrays
Correctly creating and passing argument lists is now simple
- Parameter transformation
`${parameter@Q}` makes it easy to correctly quote a string so that it
can be safely re-evaluated by the interpreter later.

On iTerm, the shell command used to render the preview is now passed to
osascript via a named pipe: `$FIFO_OSASCRIPT`. By not embedding the
shell command directly, we now no longer need to worry about osascript's
quoting rules. It's not perfect, because $SHELL and $TMPDIR might
contain naughty characters, but it's quite unlikely to happen.
2023-04-19 08:20:41 +07:00
Arun 621dbba02e
Merge pull request #1628 from spfanning/patch-1
Support wezterm split size percentage in preview-tui
2023-04-14 18:54:22 +05:30
spfanning 63891578d7
Support wezterm split size percentage 2023-04-13 15:50:31 -05:00
Arun Prakash Jana 8a1dce888a
config option to specify archive mounter utility 2023-04-14 01:47:50 +05:30
Arun Prakash Jana 9319b638e7
Revert variety 2023-04-13 19:10:07 +05:30
Arun Prakash Jana 6dd8cf8b4d
Happy Birthday nnn!
Prepare for release v4.8 Spritz!
2023-04-13 18:37:42 +05:30
Arun 18b5371d08
Merge pull request #1621 from kianmeng/fix-typos
Fix typos
2023-04-04 21:06:08 +05:30
Kian-Meng Ang 3d1bc6e8e5 Fix typos
Found via `codespell -L noice,nd,fils,numer,caf,iterm`
2023-04-03 12:49:03 +08:00
Arun 79007074f7
Merge pull request #1619 from yoshiyoshyosh/icon-jxl
add jpeg xl icon
2023-03-29 22:09:52 +05:30
yosh 98d3b2135d add jxl icon 2023-03-28 11:44:38 -04:00
Arun a3759abd4e
Merge pull request #1616 from N-R-K/quitcd
add shell_escape() to properly escape filenames fed to shell
2023-03-28 04:28:04 +05:30
NRK 57882ffab7 add shell_escape() to properly escape filenames fed to shell
Fixes: https://github.com/jarun/nnn/issues/1615
2023-03-22 10:09:39 +06:00
Arun Prakash Jana c4678e3116 Update issue templates
Signed-off-by: Arun Prakash Jana <engineerarun@gmail.com>
2023-03-15 04:21:17 +05:30
Arun 03ae86cca4
Merge pull request #1598 from N-R-K/tilde_handling
More correct tilde handling
2023-03-10 18:15:16 +05:30
Arun 15e55f5e18
Merge pull request #1606 from mmai/patch-2
Fix paths in nushell quitcd script
2023-03-08 20:26:05 +05:30
Arun 2af79c9ad2
Merge pull request #1604 from irhl/patch-1
plugins/wallpaper: update link
2023-03-08 20:18:13 +05:30
Henri Bourcereau eaffd311d4
Fix paths in nushell quitcd script
This set the correct path to the temp nnn file when XDG_CONFIG_HOME is set. It fixes https://github.com/jarun/nnn/discussions/1605
2023-03-07 15:40:10 +01:00
NRK 003228afba add some critical comments 2023-03-05 18:43:08 +06:00
birik 8b8e3eb522
plugins/wallpaper: update link 2023-03-05 09:07:04 +00:00
Arun 9656c809d2
Merge pull request #1602 from mmai/patch-1
Create quitcd script for nushell
2023-03-02 05:09:23 +05:30
Henri Bourcereau 69882b3bff
Create quitcd script for nushell 2023-02-28 16:26:36 +01:00
NRK 3a30211e6c handle tilde more strictly in mkpath and abspath
otherwise, if a file is named "~" it will get incorrectly expanded into
$HOME and disaster can happen.
2023-02-26 18:13:26 +06:00
Arun 2a38132012
Merge pull request #1597 from amalgame21/master
Add old 1997-2003 .doc and .xls preview support
2023-02-26 07:33:57 +05:30
NRK 8dbd9da0cc convert_tilde: return whether the conversion was done or not 2023-02-25 21:15:55 +06:00
NRK a59a91c312 handle tilde more correctly
closes: https://github.com/jarun/nnn/issues/1596
2023-02-25 21:15:46 +06:00
amalgame21 1dc4c96139
Add old 1997-2003 .doc and .xls support 2023-02-25 09:52:33 +00:00
Arun 9503703517
Merge pull request #1593 from luukvbaal/preview-tui
Preview-tui hide terminated/broken pipe messages
2023-02-20 19:42:15 +05:30
Luuk van Baal 675e50c941
Preview-tui hide terminated/broken pipe messages
Fix #1583, close #1591
2023-02-19 21:55:07 +01:00
Arun a4745272db
Merge pull request #1592 from N-R-K/nmv_tmp_cleanup
nmv: ensure the tmpfile is cleaned up in all cases
2023-02-19 22:27:36 +05:30
Jacob Moena 2dc7f19be0
Added patch for colemak keyboard layout. Existing renamed to colemak-dh (#1587)
* Added patch for colemak keyboard layout. Existing renamed

to colemak-dh

* Missed two spots of O_COLEMAK

* Update check-patches.sh
2023-02-19 17:22:32 +01:00
NRK bc6a09475d nmv: ensure the tmpfile is cleaned up in all cases
currently, there's a couple exit paths where the tmpfile doesn't get
cleaned up.
2023-02-19 21:14:53 +06:00
Arun Prakash Jana b874da395c
Update copyright year 2023-02-19 08:28:20 +05:30
Arun b49cc28d80
Merge pull request #1589 from N-R-K/prefer_sel
fix shellcheck issues
2023-02-17 21:00:44 +05:30
NRK 8c23c3da4e fix shellcheck issues 2023-02-17 20:12:07 +06:00
Arun f1c85b977a
Merge pull request #1588 from N-R-K/prefer_sel
nmv: prefer selection if -u is active
2023-02-17 19:30:59 +05:30
NRK 4867fa2bc7 plugin-helper: add nnn_use_selection() 2023-02-17 19:54:36 +06:00
NRK 9cc4b66868 export NNN_PREFER_SELECTION to all plugins 2023-02-17 19:24:45 +06:00
NRK 8ad5c87107 nmv: prefer selection if -u is active
the rename plugin always asks for "selection vs current" even when -u
flag is active. pass it to the plugin via `NNN_PREFER_SELECTION` so that
there's less distracting prompts.
2023-02-17 19:22:46 +06:00
Arun 9357825b34
Merge pull request #1586 from luukvbaal/preview-tui
Preview-tui restore current working directory
2023-02-17 18:42:50 +05:30
Luuk van Baal fc26493602
Preview-tui restore current working directory 2023-02-17 03:02:01 +01:00
Arun ade477e705
Merge pull request #1585 from luukvbaal/preview-tui
Preview-tui hide wezterm split-pane output
2023-02-17 07:18:35 +05:30
Luuk van Baal 08d2ba0b5d
Preview-tui hide wezterm split-pane output 2023-02-17 01:45:17 +01:00
Arun Prakash Jana bbfb16db42
Update readme 2023-02-13 01:05:36 +05:30
Arun d7bfe38728
Merge pull request #1580 from luukvbaal/preview-tui
Preview-tui!: refactor environment variables
2023-02-12 07:58:58 +05:30
Luuk van Baal 80c07741e5
Preview-tui!: refactor environment variables
Problem:    List of environment variables is copied for each previewer.
            Environment variable names are too general.
Solution:   Parameterize environment variable flags with static list of
            variables. Prepend user-facing variables with `NNN_`.
2023-02-11 03:09:56 +01:00
Arun 3739aab578
Merge pull request #1578 from kuntau/wezterm-preview-support
feat(preview-tui): add `wezterm` support
2023-02-04 07:04:24 +05:30
Nizamuddin Sulieman 70204a2d0f
Update plugins/preview-tui
use `$WEZTERM_PANE` instead, since `$WEZTERM_UNIX_SOCKET` is not set on Linux

Co-authored-by: luukvbaal <31730729+luukvbaal@users.noreply.github.com>
2023-02-04 07:36:57 +08:00
Nizamuddin Sulieman 1ad6d30a36 feat(preview-tui): use built in iTerm2 image protocol if
`NNN_PREVIEW_IMGPROG` is not specified. Add some notes.
2023-02-02 18:25:39 +08:00
Nizamuddin Sulieman 0ac8b7aa54 feat(preview-tui): add wezterm support 2023-02-02 16:14:56 +08:00